hacsoc / the_jolly_advisor

26%

master: 37%

LAST BUILD ON BRANCH fix-set-course

branch: fix-set-course

CHANGE BRANCH

x

Reset

• fix-set-course
• active-tab
• adapters
• cleanup-importer
• dependabot/bundler/loofah-2.3.1
• dependabot/bundler/rack-2.0.8
• direct-routes
• explorer-autocomplete
• fix-coveralls
• fix-pg-patch
• fix-scheduler-view
• master
• push-coverage-in-CI
• rails-5-2-beta
• remove-database-cleaner
• scheduler-fix
• sis-importer-tests
• tips-and-reviews
• update-gems
• vcr

Build # 751

Build Type

push

travis-ci

Committed by ajm188

Commit Message

Fix NoMethodError in set_course

The NoMethodError came from the regex match. If the regex failed to
match the course id, then `.captures` would be called on `nil`. So we
wrap the entire method in a `rescue` block that will result in a 404 if
any error occurs.

Then, to clean things up a bit more, use the `!` version of `find_by` so
that ActiveRecord raises an exception if no record is found. Now, all
error paths will hit the same `rescue`.

Run Details

208 of 787 relevant lines covered (26.43%)

2.59 hits per line