guardian / support-service-lambdas

62%

master: 63%

LAST BUILD ON BRANCH potential-endpoint-stop-multiple-zuora-calls

branch: potential-endpoint-stop-multiple-zuora-calls

CHANGE BRANCH

x

Reset

• potential-endpoint-stop-multiple-zuora-calls
• FIX-bad-sf-reuse-refactor
• Move-credit-calculation-into-main-for-comprehension
• RENAME_TO_support-service-lambdas
• abstract-voucher-subscription-model
• add-Amendment-to-zuora-datalake-export
• add-Contact-to-zuora-datalake-export
• add-Invoice-to-zuora-datalake-export
• add-InvoiceItem-to-zuora-datalake-export
• add-InvoicePayment-to-zuora-datalake-extract
• add-Payment-to-zuora-datalake-export
• add-RatePlan-to-zuora-datalake-export
• add-RatePlanChargeTier-to-zuora-datalake-export
• add-Refund-to-zuora-datalake-export
• add-Subscription-to-zuora-datalake-export
• add-current-sunday-voucher-model
• add-direct-debit-mandate-failure-emails
• add-direct-debit-payment-failure-emails
• add-everyday-voucher-holiday-stop
• add-fields-to-amendment-zuora-datalake-export
• add-guardian-weekly-offer-field
• add-httpclient-with-long-timeout
• add-identityid-sf
• add-path-api-gateway-request
• add-paymentmethod-to-zuora-datalake-export
• add-price-to-potential-holiday-stop-endpoint
• add-safety-day-to-when-processor-runs
• add-salesforce-cancellation-survery-trigger
• add-serviceActivationDate-to-Subscription-zuora-datalake-export
• add-sfcontact-id-to-sqs
• add-sixday-voucher-holiday-stop
• add-weekend-voucher-holiday-stop-processor-and-api
• alarm-minor-fix
• apply-frj-pr-417-comments
• apply-gdpr-DoNotProcess-for-zuora-account-on-ophan-side
• apply-sunday-voucher-holiday-stop-in-the-next-billing-period
• backfill-guest-account
• backfill-multiple-zuora
• begin-factoring-out-holiday-stop-processing-commonalities
• bugFix
• calculate-sunday-voucher-credit-amount
• camelcaseObjs
• caseQuery
• catalog
• catalog_2
• catalog_3
• catalog_json_changes
• ccExpiryFields
• clarify-calculation-of-actioned-stopped-dates
• clarify-zuora-writes-from-salesforce-writes
• cleanBucket
• clear-zuora-identityid
• contact-merge-identityid-check
• contact-merge-identityids
• contact-merge-runner
• contactFlags
• contributions-email-move
• copy-firstname-merge
• copy-losing-address
• copy-sf-address
• coveralls
• coveralls-badge-branch
• createVoucherSub
• credit-calc
• credit-calc-frj
• dateValidation
• dateValidation_refactor
• dd-mandate-sync
• delete-dead-file
• dev-weekend-voucher-holiday-api
• discountExport
• doc-template-field-personalisation
• document-full-export-and-manual-re-export
• document-invoiceitem-full-export
• dont-re-merge
• dont-use-winning-identityid
• email-case-ignore
• email-via-sqs
• email_changes
• email_fix
• error-message-on-500
• factor-out-NextInvoiceStartDate
• fetch-first-availabile-date-for-sundays
• fetch-impacted-publications-for-sundays
• fetch-sunday-voucher-holiday-requests
• fetch-sunday-voucher-holiday-stops-from-salesforce
• first-available-date-contract-acceptance-date
• fix-sf-url-refactor
• fix-typo
• fix-zuora-datalake-export-trigger-input
• fixPolicy
• fixSubsEffectsTest
• fix_play-json-extensions_vuln
• gd-identity-auth-core
• get-holiday-stops-api-for-weekend
• getData_refactor
• google-docs
• handle-guardian-weekly-with-n-for-n-intro-plan
• hardCodedCatalogValues
• holiday-credit-estimation-for-n-for-n
• holiday-stop-api
• holiday-stop-api-README
• holiday-stop-api-use-sf-contact-id
• holiday-stop-estimated-credits-save-on-create
• holiday-stop-restructure-detail-table
• holiday-stop-weekend-voucher-model
• holiday-stop-within-n-for-n-intro-plan
• httpop-cancellation-sf
• improve-backfill
• improve-performance-of-potentials-credit-estimation
• jfsoul-patch-1
• jw-catalog-alarm
• jw-dd-response-code
• jw-payment-errors
• jw-remove-alarm
• jw-remove-todo
• kc-alarm
• kc-auth
• kc-backfill
• kc-backfill-readme
• kc-backfill-stage
• kc-cfn
• kc-credit
• kc-credit-date
• kc-date-calc
• kc-desc
• kc-dup-fix
• kc-effective-date
• kc-err-improve
• kc-gw-holiday-stop
• kc-handler
• kc-hs-confirm
• kc-hs-max-time
• kc-hsp-alert
• kc-hsp-timeout
• kc-ignore-cancelled
• kc-lambda-fix
• kc-logging
• kc-logging-2
• kc-no-backfiller
• kc-no-dup
• kc-readme
• kc-schedule
• kc-sf-dedup
• kc-sf-fix
• kc-sf-write
• kc-stop-backfill
• kc-stop-date
• kc-sub-amend-detail
• kc-subscription
• kc-tests
• kc-travis
• kc-wip
• kc-year-fix
• kc-zuora-fetch
• kc-zuora-ids
• kc-zuora-local-read
• kc-zuora-sf
• kelvin-chappell-patch-1
• kougios/417-add-i-movo-contract-salesforce-data-to-the-lake
• lambdaVersionTest
• lm-add-batch-email-lambda
• lm-email-batch-lambda
• lm-log-retention-policy-batch-emailer
• longer-catalog-timeout
• make-names-more-specific-for-holiday-credit-rpc-update-request
• master
• merge-gnm-addresses
• metric-push-api
• mill-builds
• minorFix
• moreFixes
• new_product_annual_contribution
• point-all-alarms-to-fulfilment-dev
• post-httpop-sf
• potentials-endpoint-for-weekend
• prevent-errors-short-circuiting-processing
• readS3Catalog
• refactor-zuora-client-deserialisation
• remove-deprecated-hoilday-stops-endpoints
• remove-duplicate-column
• remove_extra_fields
• replace-log4j-with-logback
• revert-444-revert-440-kc-date-calc
• safe-digital-voucher
• salesforce-holiday-stop-lib
• salesforce_raw
• salesforce_raw_changes
• same-discount-product-is-reused-for-all-products
• scheduleCardExpiry
• scheduleCases
• scheduleDiscount
• scheduleExport
• scheduleSubs
• send-zuora-export-alarm-to-fulfilment-dev
• ses-email-effect
• sf-case-gaData
• sf-export-have-single-cancellation-reason
• sf-httpop-everywhere
• sf-step-dsl
• sfExportExtraFields
• sfFields
• shared-sf-set-identityid
• simplify-nextAvailableDate-calculation
• start-new-zuora-export-stateful-session
• step-dsl
• step-dsl-gaia
• step-dsl-wait
• stopped-publication-date-should-be-after-current-invoice-start-date
• sunday-holiday-stops-skeleton
• sync
• tweak-alarm-for-sf-gocardless-sync
• update-doc
• update-identityid-sf
• update-sf-email
• updateOphanBucket
• use-enumeratum-for-case-exhaustion
• validate-incoming-planid
• validate_voucher
• validation_tweak
• voucher-confirmation-email
• wire-in-sunday-voucher-credit-calculation
• yf-add-home-del-postcodes
• yf-add-logging-for-identity-users
• zuora-does-not-allow-amending-with-holiday-stop-cancelled-subscriptions
• zuora-replace-email

Build # 1878

Build Type

Pull #424

travis-ci

Committed by web-flow

Commit Message

moving zuora calls out of credit calculator to improve readability

Pull Request Pull Request #424: stop holiday stops api making multiple unnecessary zuora calls to get subscription

Run Details

19 of 19 new or added lines in 3 files covered. (100.0%)

2486 of 4027 relevant lines covered (61.73%)

0.62 hits per line