gravitystorm / openstreetmap-website

95%

master: 96%

LAST BUILD ON BRANCH change_table

branch: change_table

CHANGE BRANCH

x

Reset

Sync Branches

• change_table
• about
• account_deletion
• accounts_controller
• action_order
• activerecord_or
• add_debug
• align_structure
• ambiguous_operator_precedence
• anton_maintainer
• apache
• api_actions
• api_around_action
• api_call_handlers
• assert_content
• assignments
• attribution_changes
• auto_extension
• avoid_html
• avoid_id
• belongs_to
• bigint_sequences
• blank_issue
• bootstrap_5
• bootstrap_5_2
• bootstrap_5_3
• bootstrap_release
• brakeman
• browser-gem
• bundler
• bundle_update
• buttons
• button_variant
• centre_point
• changes
• changeset_browse
• changeset_render
• code_examples
• combine_scss
• comment_padding
• comments
• common_details
• communities_offline
• complex_flash
• conditional_tags
• confirmation_from
• content_tag
• cooldown
• copyright_lang
• count_number
• coveralls_revert
• cpk_update
• created_at
• css
• dartsass-sprockets
• dashboard
• default_css
• deletion_params
• dependabot/github_actions/actions/cache-2.1.6
• dependabot/github_actions/actions/cache-2.1.7
• dependabot/github_actions/actions/cache-3
• dependabot/github_actions/actions/cache-v2.1.4
• dependabot/github_actions/actions/cache-v2.1.5
• dependabot/github_actions/actions/checkout-2.3.5
• dependabot/github_actions/actions/checkout-2.4.0
• dependabot/github_actions/actions/checkout-3
• dependabot/github_actions/actions/setup-ruby-1.1.3
• dependabot/github_actions/coverallsapp/github-action-1.1.3
• dependabot/github_actions/coverallsapp/github-action-1.2.0
• dependabot/github_actions/coverallsapp/github-action-1.2.2
• dependabot/github_actions/coverallsapp/github-action-1.2.3
• dependabot/github_actions/coverallsapp/github-action-1.2.4
• dependabot/npm_and_yarn/eslint-7.16.0
• dependabot/npm_and_yarn/eslint-7.17.0
• dependabot/npm_and_yarn/eslint-7.18.0
• dependabot/npm_and_yarn/eslint-7.19.0
• dependabot/npm_and_yarn/eslint-7.20.0
• dependabot/npm_and_yarn/eslint-7.21.0
• dependabot/npm_and_yarn/eslint-7.22.0
• dependabot/npm_and_yarn/eslint-7.23.0
• dependabot/npm_and_yarn/eslint-7.24.0
• dependabot/npm_and_yarn/eslint-7.25.0
• dependabot/npm_and_yarn/eslint-7.26.0
• dependabot/npm_and_yarn/eslint-7.27.0
• dependabot/npm_and_yarn/eslint-7.28.0
• dependabot/npm_and_yarn/eslint-7.29.0
• dependabot/npm_and_yarn/eslint-7.30.0
• dependabot/npm_and_yarn/eslint-7.31.0
• dependabot/npm_and_yarn/eslint-7.32.0
• dependabot/npm_and_yarn/eslint-8.0.0
• dependabot/npm_and_yarn/eslint-8.0.1
• dependabot/npm_and_yarn/eslint-8.1.0
• dependabot/npm_and_yarn/eslint-8.10.0
• dependabot/npm_and_yarn/eslint-8.11.0
• dependabot/npm_and_yarn/eslint-8.12.0
• dependabot/npm_and_yarn/eslint-8.13.0
• dependabot/npm_and_yarn/eslint-8.14.0
• dependabot/npm_and_yarn/eslint-8.15.0
• dependabot/npm_and_yarn/eslint-8.16.0
• dependabot/npm_and_yarn/eslint-8.17.0
• dependabot/npm_and_yarn/eslint-8.18.0
• dependabot/npm_and_yarn/eslint-8.2.0
• dependabot/npm_and_yarn/eslint-8.20.0
• dependabot/npm_and_yarn/eslint-8.21.0
• dependabot/npm_and_yarn/eslint-8.22.0
• dependabot/npm_and_yarn/eslint-8.23.0
• dependabot/npm_and_yarn/eslint-8.23.1
• dependabot/npm_and_yarn/eslint-8.25.0
• dependabot/npm_and_yarn/eslint-8.26.0
• dependabot/npm_and_yarn/eslint-8.27.0
• dependabot/npm_and_yarn/eslint-8.28.0
• dependabot/npm_and_yarn/eslint-8.3.0
• dependabot/npm_and_yarn/eslint-8.30.0
• dependabot/npm_and_yarn/eslint-8.32.0
• dependabot/npm_and_yarn/eslint-8.33.0
• dependabot/npm_and_yarn/eslint-8.34.0
• dependabot/npm_and_yarn/eslint-8.35.0
• dependabot/npm_and_yarn/eslint-8.4.0
• dependabot/npm_and_yarn/eslint-8.4.1
• dependabot/npm_and_yarn/eslint-8.5.0
• dependabot/npm_and_yarn/eslint-8.6.0
• dependabot/npm_and_yarn/eslint-8.7.0
• dependabot/npm_and_yarn/eslint-8.8.0
• dependabot/npm_and_yarn/eslint-8.9.0
• dependabot/npm_and_yarn/js-cookie-3.0.1
• dependabot/npm_and_yarn/leaflet-1.8.0
• dependabot/npm_and_yarn/leaflet-1.9.0
• dependabot/npm_and_yarn/leaflet-1.9.1
• dependabot/npm_and_yarn/leaflet-1.9.2
• dependabot/npm_and_yarn/leaflet-1.9.3
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.72.2
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.73.0
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.74.0
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.74.1
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.76.0
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.76.1
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.78.0
• dependabot/npm_and_yarn/leaflet.locatecontrol-0.79.0
• dependabot/npm_and_yarn/ohauth-1.0.1
• dependabot/npm_and_yarn/qs-6.10.0
• dependabot/npm_and_yarn/qs-6.10.1
• dependabot/npm_and_yarn/qs-6.10.2
• dependabot/npm_and_yarn/qs-6.10.3
• dependabot/npm_and_yarn/qs-6.10.5
• dependabot/npm_and_yarn/qs-6.11.0
• dependabot/npm_and_yarn/qs-6.11.1
• dependabot/npm_and_yarn/qs-6.9.6
• devise_passwords
• dev_populate
• diary_comments
• division
• docker_compose
• docker_jammy
• docs
• documentatation
• doorkeeper
• em
• emergency
• erblint_deprecations
• erb_safety
• errors_add
• even_more_bootstrap
• external_redirect
• faster_tests
• find_by
• fix_registration
• flash
• floats_and_borders
• framework_defaults
• header_height
• heading-sizes
• html_safe
• i18n_tasks
• i18n_validations
• ignore_engines
• image_optim_development
• image_sizes
• implicit_association
• issue_reassign
• issues_secondary_actions
• issue_templates
• italics
• jammy2
• json_root_attributes
• leaflet_focus
• locale_param_3
• locatecontrol_es5
• login_bootstrap
• login_css
• login_form
• login_path
• mailto
• map-ui
• margin
• margin_top
• markdown_test
• master
• messages
• minitest_focus
• more_bootstrap
• more_bootstrap_forms
• named_paths
• no-global-text-align
• no_html
• no_html_2
• no_html_copyright
• notes_refactor
• no_zero
• osmf_wiki_links
• params_fix
• paranoid_email_reset
• postgresql_version
• postgres_version
• potlatch_preferences
• preferences_flash
• preferred_something
• pr_guidance
• pt_br
• rails_7_2_1
• rails_version
• rake
• rake_extension
• raw_html
• rbenv
• readme_trac
• redundant_validation
• refactor_changeset_comment_feed
• regexp_escape
• remove_id_defaults
• remove_old_richtext_helper
• remove_tile_for_point_sql
• require_xml
• reverse_button
• richtext_form_2
• richtext_refactor
• rubocop-minitest-focus
• rubocop_rails_bug
• rubocop_rake
• ruby_simplifications
• sanitize
• sanitize_2
• search_forms_bootstrap
• search_wrap
• secondary
• secondary-actions
• security_policy
• sessions
• settings_refactor
• settings_tabs
• skip_intermediate_lengths
• soft_destroy_tokens
• sprockets_direct
• style_tweaks
• styling
• symlinks
• system_timer
• test_all
• test_filename
• tests
• thumbnails
• time_helpers
• timezone_in_tests
• trace_index
• trace_job_option
• tracepoint_to_xml
• traces-header
• traces_index_2
• ubuntu_workflows
• unused_translations
• updated_by_resolved_issue
• use_factories
• user_activate_docs
• user_blocks_dl
• user_blocks_form
• user_blocks_short_duration
• user_destroy
• user_forms
• userinformation
• user_menu_focus
• users_controller
• user_status
• user_suspended
• user_terms_login_redirect
• vagrant_bundle
• vagrant_db_create
• viewport
• vips-nomagick
• wait_for_selector
• where_in
• whitespace
• wikipedia_fragments
• yaml_quoting
• yarn_install

Build # 9585711291

Build Type

push

github

Committed by gravitystorm

Commit Message

Disable Rails/BulkChangeTable cop

If you have multiple alter commands in a migration (like adding two
columns to an existing table) this cop will suggest combining them using
`change_table :foo, :bulk => true`.

However, Strong Migrations can't inspect `change_table` blocks, and
therefore suggests using `safety_assured`, which mostly defeats the
purpose of using strong_migrations in the first place.

Instead, we should stick with the individual alter commands. Since
postgres runs DDL changes in a transaction anyway, there is not enough
benefit from the `change_table` approach to be worth losing the
safety net of the Strong Migrations checks.

Run Details

6363 of 6692 relevant lines covered (95.08%)

1218.99 hits per line