gookit / config

98%

master: 98%

LAST BUILD ON BRANCH fix-duration-parse-string

branch: fix-duration-parse-string

CHANGE BRANCH

x

Reset

• fix-duration-parse-string
• 1.x
• bugfix-exists
• dependabot/add-v2-config-file
• dependabot/github_actions/WillAbides/setup-go-faster-1.10.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.10.1
• dependabot/github_actions/WillAbides/setup-go-faster-1.11.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.12.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.13.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.14.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.15.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.19.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.8.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.9.0
• dependabot/github_actions/WillAbides/setup-go-faster-1.9.1
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/github/codeql-action-3
• dependabot/github_actions/github/codeql-action-4
• dependabot/github_actions/github/codeql-action-4.37.3
• dependabot/github_actions/github/codeql-action-4.37.4
• dependabot/github_actions/morphy2k/revive-action-2.4.1
• dependabot/github_actions/morphy2k/revive-action-2.5.0
• dependabot/github_actions/morphy2k/revive-action-2.5.1
• dependabot/github_actions/morphy2k/revive-action-2.5.2
• dependabot/github_actions/morphy2k/revive-action-2.5.3
• dependabot/github_actions/morphy2k/revive-action-2.5.4
• dependabot/github_actions/morphy2k/revive-action-2.5.6
• dependabot/github_actions/softprops/action-gh-release-2
• dependabot/github_actions/softprops/action-gh-release-3
• dependabot/go_modules/github.com/BurntSushi/toml-1.2.0
• dependabot/go_modules/github.com/BurntSushi/toml-1.2.1
• dependabot/go_modules/github.com/BurntSushi/toml-1.6.0
• dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.5.0
• dependabot/go_modules/github.com/goccy/go-json-0.10.1
• dependabot/go_modules/github.com/goccy/go-json-0.10.2
• dependabot/go_modules/github.com/goccy/go-json-0.10.6
• dependabot/go_modules/github.com/goccy/go-yaml-1.10.0
• dependabot/go_modules/github.com/goccy/go-yaml-1.10.1
• dependabot/go_modules/github.com/goccy/go-yaml-1.11.0
• dependabot/go_modules/github.com/goccy/go-yaml-1.11.1
• dependabot/go_modules/github.com/goccy/go-yaml-1.11.2
• dependabot/go_modules/github.com/goccy/go-yaml-1.19.2
• dependabot/go_modules/github.com/gookit/goutil-0.3.1
• dependabot/go_modules/github.com/gookit/goutil-0.3.10
• dependabot/go_modules/github.com/gookit/goutil-0.3.12
• dependabot/go_modules/github.com/gookit/goutil-0.3.2
• dependabot/go_modules/github.com/gookit/goutil-0.3.5
• dependabot/go_modules/github.com/gookit/goutil-0.3.7
• dependabot/go_modules/github.com/gookit/goutil-0.3.8
• dependabot/go_modules/github.com/gookit/goutil-0.3.9
• dependabot/go_modules/github.com/gookit/goutil-0.5.1
• dependabot/go_modules/github.com/gookit/goutil-0.5.12
• dependabot/go_modules/github.com/gookit/goutil-0.5.13
• dependabot/go_modules/github.com/gookit/goutil-0.5.2
• dependabot/go_modules/github.com/gookit/goutil-0.5.4
• dependabot/go_modules/github.com/gookit/goutil-0.5.5
• dependabot/go_modules/github.com/gookit/goutil-0.5.6
• dependabot/go_modules/github.com/gookit/goutil-0.5.7
• dependabot/go_modules/github.com/gookit/goutil-0.6.10
• dependabot/go_modules/github.com/gookit/goutil-0.6.11
• dependabot/go_modules/github.com/gookit/goutil-0.6.12
• dependabot/go_modules/github.com/gookit/goutil-0.6.5
• dependabot/go_modules/github.com/gookit/goutil-0.6.7
• dependabot/go_modules/github.com/gookit/goutil-0.6.8
• dependabot/go_modules/github.com/gookit/goutil-0.7.4
• dependabot/go_modules/github.com/gookit/goutil-0.7.5
• dependabot/go_modules/github.com/gookit/goutil-0.7.6
• dependabot/go_modules/github.com/gookit/goutil-0.8.0
• dependabot/go_modules/github.com/gookit/ini/v2-2.0.5
• dependabot/go_modules/github.com/gookit/ini/v2-2.0.6
• dependabot/go_modules/github.com/gookit/ini/v2-2.0.7
• dependabot/go_modules/github.com/gookit/ini/v2-2.0.8
• dependabot/go_modules/github.com/gookit/ini/v2-2.1.1
• dependabot/go_modules/github.com/gookit/ini/v2-2.1.2
• dependabot/go_modules/github.com/gookit/ini/v2-2.2.1
• dependabot/go_modules/github.com/gookit/ini/v2-2.2.2
• dependabot/go_modules/github.com/gookit/properties-0.2.0
• dependabot/go_modules/github.com/gookit/properties-0.3.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.12.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.13.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.14.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.14.1
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.16.1
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.16.2
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.17.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.18.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.19.0
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.19.1
• dependabot/go_modules/github.com/hashicorp/hcl/v2-2.9.1
• dependabot/go_modules/github.com/imdario/mergo-0.3.10
• dependabot/go_modules/github.com/imdario/mergo-0.3.11
• dependabot/go_modules/github.com/imdario/mergo-0.3.12
• dependabot/go_modules/github.com/imdario/mergo-0.3.13
• dependabot/go_modules/github.com/imdario/mergo-0.3.14
• dependabot/go_modules/github.com/imdario/mergo-0.3.15
• dependabot/go_modules/github.com/imdario/mergo-0.3.16
• dependabot/go_modules/github.com/mitchellh/mapstructure-1.3.3
• dependabot/go_modules/github.com/mitchellh/mapstructure-1.4.0
• dependabot/go_modules/github.com/mitchellh/mapstructure-1.4.1
• dependabot/go_modules/github.com/mitchellh/mapstructure-1.5.0
• dependabot/go_modules/github.com/stretchr/testify-1.6.1
• dependabot/go_modules/github.com/stretchr/testify-1.7.2
• dependabot/go_modules/github.com/stretchr/testify-1.7.4
• dependabot/go_modules/github.com/stretchr/testify-1.7.5
• dependabot/go_modules/github.com/stretchr/testify-1.8.0
• dependabot/go_modules/gopkg.in/yaml.v2-2.3.0
• dependabot/go_modules/gopkg.in/yaml.v2-2.4.0
• dependabot/go_modules/gopkg.in/yaml.v3-3.0.1
• fix/201/zero-duration-unit
• inhere-patch-1
• master
• refs/tags/v2.0.18
• refs/tags/v2.0.19
• refs/tags/v2.0.20
• refs/tags/v2.0.21
• refs/tags/v2.0.22
• refs/tags/v2.0.23
• refs/tags/v2.0.25
• refs/tags/v2.0.26
• refs/tags/v2.0.27
• refs/tags/v2.1.0
• refs/tags/v2.1.1
• refs/tags/v2.1.2
• refs/tags/v2.1.3
• refs/tags/v2.1.4
• refs/tags/v2.1.5
• refs/tags/v2.1.6
• refs/tags/v2.1.7
• refs/tags/v2.1.8
• refs/tags/v2.2.0
• refs/tags/v2.2.1
• refs/tags/v2.2.2
• refs/tags/v2.2.3
• refs/tags/v2.2.4
• refs/tags/v2.2.5
• refs/tags/v2.2.6
• refs/tags/v2.2.7
• refs/tags/v2.2.8
• refs/tags/v2.2.9
• v1.0.10
• v1.0.11
• v1.0.12
• v1.0.6
• v1.0.7
• v1.0.8
• v1.0.9
• v1.1.0
• v2.0.0
• v2.0.1
• v2.0.10
• v2.0.11
• v2.0.12
• v2.0.13
• v2.0.14
• v2.0.15
• v2.0.16
• v2.0.17
• v2.0.2
• v2.0.3
• v2.0.4
• v2.0.5
• v2.0.6
• v2.0.7
• v2.0.8
• v2.0.9

Build # 28679896318

Build Type

Pull #218

github

Committed by j-ibarra

Commit Message

fix(read): Duration parses Go duration strings (e.g. "300s", "1h30m")

The Config.Duration getter read the value as an int64 and returned
time.Duration(n) — i.e. nanoseconds — so a duration string like "300s" could
not be read at all (it failed integer parsing and yielded 0), and a bare
number was interpreted as nanoseconds. Duration parsing existed only on the
struct-binding path (ParseTime decode hook), not the getter.

Parse the stored value as a Go duration string first (time.ParseDuration),
falling back to the previous int64-nanoseconds behaviour for bare integers,
then to the default. Backwards compatible; adds a getter test.

Pull Request Pull Request #218: fix(read): Duration() parses Go duration strings (e.g. "300s", "1h30m")

Coverage Stats

13 of 14 new or added lines in 1 file covered. (92.86%)

5 existing lines in 1 file now uncovered.

1223 of 1246 relevant lines covered (98.15%)

5.71 hits per line