googledatalab / pydatalab

78%

master: 78%

LAST BUILD ON BRANCH requirejs

branch: requirejs

CHANGE BRANCH

x

Reset

• requirejs
• add_magic_test
• add_tests
• analyze_printing
• argparse
• bq
• chmeyers-bqcreate1
• chmeyers-helpformat
• chmeyers-py3http
• cm_plot_size
• composer_integration
• default_runtime
• dependabot/pip/solutionbox/image_classification/pillow-6.2.0
• dependabot/pip/solutionbox/ml_workbench/tensorflow/pillow-6.2.0
• dependabot/pip/solutionbox/ml_workbench/tensorflow/tensorflow-1.15.0
• dependabot/pip/solutionbox/ml_workbench/tensorflow/tensorflow-1.15.2
• dependabot/pip/solutionbox/ml_workbench/tensorflow/tensorflow-1.15.4
• dependabot/pip/solutionbox/ml_workbench/tensorflow/tensorflow-2.3.1
• dependabot/pip/solutionbox/ml_workbench/xgboost/pillow-6.2.0
• dependabot/pip/solutionbox/ml_workbench/xgboost/tensorflow-1.15.0
• dependabot/pip/solutionbox/ml_workbench/xgboost/tensorflow-1.15.2
• dependabot/pip/solutionbox/ml_workbench/xgboost/tensorflow-1.15.4
• dependabot/pip/solutionbox/ml_workbench/xgboost/tensorflow-2.3.1
• fix/sample_bug
• fix_url
• fixing_test_spew
• fixvocab
• format_parameters
• google-datalab-yebrahim
• help_str
• img_missing_count
• job_name
• local_paths
• master
• ml
• mlmagictarball
• mltarball
• mltoolbox
• mltoolbox1
• mlw
• mlw1
• mlworkbench
• mlws
• mlwtest
• multifeatures
• ojarjur-patch-1
• ojarjur-patch-2
• ojarjur-patch-3
• ojarjur/make-retriever-methods-consistent
• ojarjur/pandas-profiling-version
• ojarjur/silence_default_module_warnings
• ojarjur/update-side-output-value
• ojarjur/version-1-1-3
• one_prediction
• pin-google-cloud-monitoring-version
• qimingj-patch-1
• qimingj-patch-1-1
• qimingj-patch-1-2
• qimingj-patch-2
• rajivpb-airflow-args
• rajivpb-airflow-macros
• rajivpb-apache-airflow
• rajivpb-bq-pipelines
• rajivpb-bq-sql-parameters
• rajivpb-canned-parameters
• rajivpb-catch-documentation
• rajivpb-catchup
• rajivpb-code-review-fixes
• rajivpb-composer
• rajivpb-composer-bucket
• rajivpb-composer-integration
• rajivpb-composer-setup
• rajivpb-contrib
• rajivpb-copy-to-gcs
• rajivpb-csv
• rajivpb-csv-2
• rajivpb-datetime
• rajivpb-default-data-source
• rajivpb-documentation
• rajivpb-e2e
• rajivpb-email
• rajivpb-end-to-end-fixes
• rajivpb-fix-broken-output
• rajivpb-input
• rajivpb-input-query
• rajivpb-load-export
• rajivpb-load-extract-macros
• rajivpb-location
• rajivpb-logging
• rajivpb-mode
• rajivpb-mode-external
• rajivpb-mode-refactoring
• rajivpb-more-fixes
• rajivpb-myriad-fixes
• rajivpb-nits
• rajivpb-nodash
• rajivpb-parameters
• rajivpb-pydatalab-operators
• rajivpb-pydatalab-operators-new
• rajivpb-pydatalab-operators-parameter-merging
• rajivpb-pypi
• rajivpb-refactor
• rajivpb-remove-orchestration
• rajivpb-remove-sql-newlines
• rajivpb-requirements-txt
• rajivpb-schedule
• rajivpb-sql-template
• rajivpb-storage
• rajivpb-task-id
• rajivpb-templated-fields
• rajivpb-time-format
• rajivpb-ud-params
• rajivpb-vm-stuff
• rajivpb-xcom
• rajivpb-xcom-clone
• rajivpb-xcom2
• rajivpb-xcom2-mode
• rajivpb-xcom2-mode-external
• release-1-2-0
• remove_squeeze
• rename_mltoolbox_magic
• renameoutputdir
• runtime
• runtimeversion_note
• score2prob
• sf
• short_names
• slowanalysisprinting
• small_fixes
• sql_analyze
• tb
• tf
• tf12
• tfevents
• timezone
• topn
• update-deps
• v1.1.2
• v1.1.3
• v1.2.0

Build # 2738

Build Type

push

travis-ci

Committed by qimingj

Commit Message

Fix a performance issue that it loads require.js in each cell output unnecessarily.

I believe the glocal require js config for each cell was added because we now use an iframe for each output cell in experimental UI.

The issue is worth fixing because:

1. require js appends a unique query string parameter to require.js, which makes the file non-cachable, so each output cell needs to download the file (84KB). If the notebook includes 20+ cells (which is very common), it takes long time to load (15s+ difference on my desktop)

2. Each cell output in the notebook includes a require js config section, which makes the notebook size unnecessarily larger.

The fix is to remove the global require js config for each cell output, and add it to only the cell output that need it.

Run Details

5347 of 6884 relevant lines covered (77.67%)

0.78 hits per line