gonum / matrix

85%

master: 88%

LAST BUILD ON BRANCH matrix.Vector-is-blas64.Vector

branch: matrix.Vector-is-blas64.Vector

CHANGE BRANCH

x

Reset

• matrix.Vector-is-blas64.Vector
• ElemDiver
• add-go.1.7-drop-go-1.4
• addcholclone
• addcholdim
• addcond
• addeigsym
• addfromchol
• addgrow
• addinverse
• addpowpsd
• addsym
• addtri
• addtriangular
• addtrimul
• addtritype
• addtypes
• addviewsym
• archive
• archive-typo
• asm
• asm-dscal
• bounds
• bounds-bug
• cap
• capped
• changerowview
• changevec
• check
• chol
• cholesky-panic
• cholesky-rankone
• cholfrom
• clean-vector
• clean_tests
• cleanup-cholesky
• cleanup-doc
• close
• cmat
• comments
• conderr
• conj
• conjugate
• copy-safe
• de-zero
• deadchecks
• dense-rowcoler
• densepanic
• deprecation-notice
• det-flake
• doc-complex
• doc-fixes
• docs
• dot
• dot-vector
• drop-lugaussian
• eigen
• eigen-work
• error
• error-stack
• errors
• exp
• exp-workspace
• export-iszero
• exposevectors
• extractions
• fix-binary-ops
• fix-build-status
• fix-cholesky
• fix-docs
• fix-fails
• fix-inverse-singular
• fix-job-syev
• fix-lu
• fix-tri
• fixbenchpremul
• fixcholcheck
• fixcolerr
• fixdet
• fixdocs
• fixgrow
• fixinner
• fixiszero
• fixmulvec
• fixraw
• fixsubsetsymexample
• fixsyminner
• fixvecmul
• formatting
• go-1.5.4-and-1.6.1
• go-1.6.3-and-1.7rc2
• go-1.7.3
• go-1.7rc3
• go1.6beta2
• go1.6rc1
• go1.7beta1
• goblas
• godoc
• grow
• gsvd
• gsvd-examples
• housekeeping
• inner
• inverse_tests
• jama-comment
• lapackchol
• lapackeigen
• lint
• list-test-additions
• list-test-fixes
• lu-rankone-doc
• lu-reset
• master
• mat64-docs
• minor-cleanup
• mul-fix
• mulgen
• multrans
• mulvec
• mulvecaddtri
• mulvecsym
• names
• norm-panic
• norm-test
• offset
• only-coveralls-if-branch
• optimizeinner
• outer
• panmess
• pool
• pow
• pow-alloc
• pow-opt
• punctuation
• raw
• rawcolviewer-slice
• rc-ij
• re-view
• rebuild-always
• reduction
• remove-rowcoler
• rename-vectorer
• reset
• reuse-zeroed
• rowcolargname
• shadow
• shadow-doc
• shadow-fix
• shadow-precision
• shadow-strict
• shadow-sym
• shadow-test
• shadow-tri
• shadow-triangle
• shadow-vecs
• sokdoc
• solve
• spelling
• stale-comment-lu
• subsetsym
• svd-doc
• svd-reuse
• symadd
• syminner
• symmetric-strict
• symrankone
• symranktwo
• test-vector-data-len
• transposer-inplace
• travis-gimme
• travis-go-1.4.2
• travis-go-1.6.2
• underlying
• unused
• updateeigen
• updatesvd
• updatetravis
• use-ormqr
• usezeroed
• vec-lint
• vecsolvechol
• vector
• vector-addscaled
• vector-dot
• vector-norm
• vector-proliferation
• vector-scale
• viewer

Build # 1580

Build Type

push

travis-ci

Committed by jonlawlor

Commit Message

Changed matrix.Vector to be a type alias of blas64.Vector

This is a proof of concept and I would not dig deeply into the changes
immediately, because if you don’t like the premise then the rest is
irrelevant.

At first I was thinking about adding a BinaryMarshal and
BinaryUnmarshal to blas64.Vector to satisfy #337, but those methods are
supposed to be composable, so I thought maybe it would make sense to
add to blas64.Vector and then call from matrix.

But I’m really lazy and I’d rather not have to call it from matrix at
all.  By changing the type of matrix.Vector to blas64.Vector, it will
automatically pick up any methods from the original type.  As a bonus,
calling blas funcs on matrix vectors is a snap.  I imagine this
approach could be extended to other matrix types, and would allow
library callers to get down to a lower implementation level whenever
they want to take the gloves off.

(github autocorrect keeps trying to call this “composable" idea
“compostable”, hopefully you won’t feel the same…)

Run Details

117 of 117 new or added lines in 12 files covered. (100.0%)

3656 of 4323 relevant lines covered (84.57%)

2.54 hits per line