golang-migrate / migrate
55%
master: 54%

LAST BUILD BRANCH: pr-853-neo4j-v5
DEFAULT BRANCH: master
Repo Added
Files 59
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH oracle
branch: oracle
CHANGE BRANCH
x

coverage: 55.333% (+0.9%) from 54.432%
23456178157

Pull #1230

github

JailtonJunior94 
oracle: address all code review findings from PR #1230

## Bug fixes

### oracle.go
- Fix Lock()/Unlock() silently ignoring dbms_lock errors: replaced
  dbms_output.put_line with raise_application_error so any non-zero
  v_result causes ExecContext to return an error to the Go caller
- Fix Lock() setting isLocked=true even when the PL/SQL lock request
  fails: changed isLocked from plain bool to sync/atomic.Bool and
  replaced manual state mutation with database.CasRestoreOnErr, which
  performs a compare-and-swap only when the inner function succeeds
- Fix global lock name 'control_lock' causing unrelated migration sets
  to block each other: lock name is now derived from the migrations
  table (<table>_migrate_lock). Added dbmsLockName() helper that
  truncates the prefix to 115 chars so the total never exceeds the
  128-char limit of dbms_lock.allocate_unique
- Fix Version() returning wrong row: WHERE ROWNUM = 1 ORDER BY VERSION
  DESC is incorrect in Oracle because ROWNUM filtering is applied before
  ORDER BY, potentially returning an arbitrary row. Replaced with
  ORDER BY VERSION DESC FETCH FIRST 1 ROW ONLY (requires Oracle 12c+,
  which is the documented minimum)
- Fix SetVersion() using TRUNCATE inside a transaction: TRUNCATE is DDL
  in Oracle and issues an implicit commit, breaking the atomicity of the
  clear + insert pair. Changed to DELETE FROM
- Fix scanner.Err() unchecked in removeComments and parseMultiStatements:
  a read error or token-too-long condition would silently return partial
  SQL with a nil error. Both functions now check and return scanner.Err()
  after the scan loop
- Fix tables.Err() unchecked in Drop(): added post-loop rows.Err() check
  to detect iteration errors before executing DROP TABLE statements
- Add input validation for migrations table name via validateMigrationsTable
  (regex ^[A-Z][A-Z0-9_$#]{0,127}$) to prevent SQL injection through
  the x-migrations-table URL parameter
- Add compile-time interface assert... (continued)
Pull Request #1230: Add OracleDB support to golang-migrate

265 of 348 new or added lines in 1 file covered. (76.15%)

4643 of 8391 relevant lines covered (55.33%)

47.34 hits per line

Relevant lines Covered
8391 RELEVANT LINES 4643 COVERED LINES
47.34 HITS PER LINE
Source Files on oracle

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
23456178157 oracle oracle: address all code review findings from PR #1230 ## Bug fixes ### oracle.go - Fix Lock()/Unlock() silently ignoring dbms_lock errors: replaced dbms_output.put_line with raise_application_error so any non-zero v_result causes ExecContex... Pull #1230 JailtonJunior94 github
55.33
23452313423 oracle add suport oracle Pull #1230 JailtonJunior94 github
55.23
13318980925 oracle add suport oracle Pull #1230 JailtonJunior94 github
57.04
See All Builds (1673)