go-pkgz / routegroup

98%

master: 98%

LAST BUILD ON BRANCH fix-route-ux

branch: fix-route-ux

CHANGE BRANCH

x

Reset

• fix-route-ux
• better-root-handling
• catch-all
• cleanup
• custom-not-found
• feat/handle-root-without-redirect
• fix-405-response
• fix-issue-24-double-middleware
• fix-issue-27-notfound-vs-405
• fix-path-params-issue-22
• master
• mux-compat
• pr19
• refs/tags/v0.1.0
• refs/tags/v0.1.1
• refs/tags/v0.2.0
• refs/tags/v0.2.1
• refs/tags/v0.3.0
• refs/tags/v0.4.0
• refs/tags/v0.5.0
• refs/tags/v1.0.0
• refs/tags/v1.1.0
• refs/tags/v1.1.1
• refs/tags/v1.2.0
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.4.0
• refs/tags/v1.4.1
• refs/tags/v1.5.0
• refs/tags/v1.5.1
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• refs/tags/v1.6.0
• static-files
• update-golangci-lint

Build # 18474598086

Build Type

Pull #29

github

Committed by umputun

Commit Message

fix: preserve root lock when Route auto-creates group

When Route() is called on root bundle and auto-creates a child group, the root bundle must also be locked if the child registers routes. This ensures that router.Use() after router.Route() properly panics, maintaining the contract that middlewares cannot be added after routes.

Added test case to verify the fix and prevent regression.

Pull Request Pull Request #29: Fix Route UX: auto-create group when called on root bundle

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

205 of 209 relevant lines covered (98.09%)

45.69 hits per line