go-pkgz / lgr

95%

master: 95%

LAST BUILD ON BRANCH fix-from-slog-handler-add-source

branch: fix-from-slog-handler-add-source

CHANGE BRANCH

x

Reset

• fix-from-slog-handler-add-source
• adaptor
• add-slog-integration
• fix-ci-caching
• fix-slog-debug-and-modernize
• formatter
• levels-shortcut
• mapper
• master
• rbac
• refs/tags/v0.10.0
• refs/tags/v0.10.1
• refs/tags/v0.10.2
• refs/tags/v0.10.3
• refs/tags/v0.10.4
• refs/tags/v0.11.0
• refs/tags/v0.11.1
• refs/tags/v0.12.0
• refs/tags/v0.12.1
• refs/tags/v0.12.2
• refs/tags/v0.7.0
• refs/tags/v0.8.0
• refs/tags/v0.9.0
• v0.4.0
• v0.5.0
• v0.6.0
• v0.6.1
• v0.6.2
• v0.6.3

Build # 21886699364

Build Type

Pull #28

github

Committed by paskal

Commit Message

Fix FromSlogHandler ignoring AddSource option, closes #26

slogLgrAdapter.Logf was unconditionally adding source info as a manually-
constructed attribute, ignoring the handler's AddSource setting. The PC
passed to slog.NewRecord was also invalid (literal `2` instead of a real
program counter).

Replace manual source injection with a proper runtime.Callers PC so slog
handlers resolve source info through their own AddSource logic. Apply the
same fix to the Logger.logf slog-handler path which was passing pc=0.

Pull Request Pull Request #28: Fix FromSlogHandler ignoring AddSource option

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

474 of 501 relevant lines covered (94.61%)

239.87 hits per line