go-pkgz / flow

87%

master: 91%

LAST BUILD ON BRANCH fix-wait-deadlock

branch: fix-wait-deadlock

CHANGE BRANCH

x

Reset

• fix-wait-deadlock
• ci-lift
• ci-workflow-permissions
• deps-update
• fix-ci-caching
• fix-readme-pool-docs
• fix-submit-concurrency
• master
• modernise-go-fix
• pool
• rbac
• refs/tags/v1.2.0
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.3.3
• refs/tags/v1.3.4
• refs/tags/v1.3.5
• stabilise-flow-tests
• sync-read
• v1.0.0
• v1.1.1

Build # 32218023869

Build Type

Pull #7

github

Committed by paskal

Commit Message

fix deadlock in Wait with unbuffered response channel

Wait returned eg.Wait() directly, so workers blocked in sender on the
default unbuffered response channel could never complete and Wait hung
forever unless the cursor was consumed. Wait now drains and discards
responses until the channel is closed, then returns the errgroup error,
keeping the existing error semantics.

Wait on a pool which was never activated returns an error instead of
panicking on the nil errgroup.

Pull Request Pull Request #7: fix deadlock in Wait with unbuffered response channel

Coverage Stats

166 of 190 relevant lines covered (87.37%)

119.75 hits per line