go-pkgz / ctrl

95%

master: 95%

LAST BUILD ON BRANCH fix/http-shutdown-completion

branch: fix/http-shutdown-completion

CHANGE BRANCH

x

Reset

• fix/http-shutdown-completion
• fix/time-dependent-tests
• master
• refs/tags/v0.1.0
• refs/tags/v0.2.0
• refs/tags/v0.2.1
• update/testify-and-docs

Build # 32204739027

Build Type

Pull #3

github

Committed by paskal

Commit Message

Fix HTTP server helper reporting success before shutdown finished

Previously, RunHTTPServerWithContext published the serve result as soon as
startFn returned, and http.Server.Shutdown makes Serve return ErrServerClosed
at the start of the shutdown rather than at its end. Callers were therefore
told the server had exited while requests were still draining, and any
shutdown error, including a timeout, only reached the log.

After this change a single coordinator owns the channel: on cancellation it
awaits Shutdown, collects the serve result and only then publishes the outcome,
joining the two errors when both are present. A server that stopped on its own
is reported immediately and is not shut down, so a failed start can be retried
on it; that also holds when the cancellation lands at the same moment. A
shutdown that times out publishes the timeout without waiting on startFn on top
of the deadline it already missed, at the cost of not reporting a serving error
that surfaces afterwards.

The signature and the defaults are unchanged.

Pull Request Pull Request #3: Fix HTTP server helper reporting success before shutdown finished

Coverage Stats

40 of 48 new or added lines in 1 file covered. (83.33%)

187 of 197 relevant lines covered (94.92%)

5.43 hits per line