gatewayd-io / gatewayd-plugin-js

64%

push

github

Fix critical bugs, improve safety, and add tests/CI (#11)

* Fix critical bugs in plugin core

- Fix OnNewPool dispatching to "onConfigLoaded" instead of "onNewPool" (copy-paste bug)
- Fix OnTraffic swallowing error by returning nil instead of err
- Add sync.Mutex to protect Goja VM from concurrent access (not goroutine-safe)
- Use checked type assertion in RunFunction to prevent panics on unexpected JS return types
- Fix hardcoded "OnTrafficFromClient" in RunFunction error log to use actual function name

* Improve helper functions and replace deprecated dependency

- Add argument bounds checking to btoa, atob, and parseSQL to prevent
  panics when called with no arguments from JS
- Handle errors from base64 decode and SQL parse instead of silently
  discarding them; throw JS TypeErrors on invalid input
- Switch btoa/atob from RawStdEncoding to StdEncoding for browser
  compatibility (standard base64 with padding)
- Replace deprecated golang.org/x/exp/maps with stdlib maps/slices

* Fix copy-paste artifacts in plugin metadata

- Fix default metrics socket path from gatewayd-plugin-cache.sock to
  gatewayd-plugin-js.sock
- Update stale "Template plugin" description to reflect actual purpose

* Update GitHub Actions to latest versions

- actions/checkout v3 -> v4
- actions/setup-go v3 -> v5
- softprops/action-gh-release v1 -> v2

* Add CI workflow for testing and linting

- Add test.yaml workflow that runs on push/PR with golangci-lint,
  govulncheck, go test with coverage, and coveralls reporting
- Add .golangci.yaml configuration matching the cache plugin's style,
  with depguard rules for this project's dependencies

* Add comprehensive unit tests for plugin core

- Test RegisterFunction/RegisterFunctions with valid and missing JS functions
- Test RunFunction for success, not-found, JS error, and wrong return type
- Test GetHooks returns only registered (non-nil) hooks
- Test GetPluginConfig returns correct metadata
- Test all 21 hook methods pass t... (continued)

38 of 96 new or added lines in 2 files covered. (39.58%)

204 of 318 relevant lines covered (64.15%)

2.83 hits per line