gaborigloi / xen-api

14%

master: 21%

LAST BUILD ON BRANCH vdi_set_metadata_check

branch: vdi_set_metadata_check

CHANGE BRANCH

x

Reset

• vdi_set_metadata_check
• CA-253489-cli-check-valid-ref
• CA-253489-debug
• CA-276638
• CA-288347_master
• CA-288394
• add_cbt_checks
• add_comment
• add_snapshot_capability_check
• add_warnings_as_errors
• add_xapi_ha_mli
• alcotest
• alcotest_db_lowlevel
• alcotest_vlan
• alcotest_vm_check
• analyze_dead_code
• cbt_alcotest
• cbt_test_snapshot_clone
• check_indent
• clean_up_cbt_tests
• cleanup
• complete_vdi_info
• cov
• data_destroy_test
• db
• event_alcotest
• exclude_coverage
• exclude_coverage_comment
• exclude_coverage_file
• extend_vdi_update_allowed_ops
• feature/CBT_allow_intra_pool_sxm_when_cbt_vdis_not_moved
• feature/CBT_merge
• feature/CBT_more_robust_get_nbd_info
• feature/REQ-718/master
• feature/REQ477/vdicopy
• feature/qemu-datapath_old
• fix_alcotest
• fix_coverage
• fix_doc_upload
• fix_rpu_vdi_allowed_ops
• fix_travis_coverage
• gen
• in_db
• master
• merlin_fix
• network_event_loop_alcotest
• ocamldoc
• private/gabori/shutdown
• private/gabori/shutdown_orig
• probe_ext
• probe_ext_cli
• probe_ext_master
• qt_attach
• qt_cli
• qt_large_vdi_copy
• qt_snapshot
• qt_vdi_export_import
• qt_vm
• quicktest_fields
• remove_all_capabilites
• remove_dead_code
• remove_dead_code_database
• remove_dead_code_sm
• remove_dead_code_util
• remove_dead_code_xe-cli
• remove_qcowSR
• remove_quicktest_encodings
• remove_string_to_vdi_type
• remove_unused_quicktests
• remove_vdi_scan_operation
• rm_storage_examples
• simler_comparators
• test
• test_cli_CA-253489
• test_client
• test_vdi_set_metadata_of_pool
• travis_opam_coverage
• unit_quicktest
• update_comment
• vdi_alcotest
• xapi_crashdump_cleanup
• xapi_vdi_snapshot_check_cleanup
• xapi_vm_lifecycle_check_operation_error_cleanup

Build # 148

Build Type

push

travis-ci

Committed by gaborigloi

Commit Message

VDI.set_metadata_of_pool: only allow `metadata VDI

When we run this function from Xapi_sr.find_or_create_metadata_vdis, we
first set the type of the VDI passed to it to `metadata, so this check
is safe to add. Also, in the various VDI handling functions in Xapi_sr
and Xapi_dr, we only consider VDIs of type `metadata, so we should
enforce that a VDI that contains the metadata of a pool has type
`metadata.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>

Run Details

12908 of 89890 relevant lines covered (14.36%)

243.74 hits per line