fyne-io / fyne

62%

develop: 61%

LAST BUILD ON BRANCH simplify-comparison

branch: simplify-comparison

CHANGE BRANCH

x

Reset

• simplify-comparison
• 105-error-handling
• 3445-entry-insert
• 4922-tap-scrolling
• Jacalz-patch-1
• add-rowwrap-layout
• add_new_uniforms_to_other_drivers
• antialias
• appdata-updates
• async-map-helper
• avoid-double-renderer-lookups
• better-ci-infrastructure
• better-inline-window-close
• binding-cleanup-generic
• binding-cleanup-leftovers
• binding-convertion-cleanup
• binding-file-structure-rework
• binding-func-scheduling
• binding-thread-docs
• binding-trigger-faster
• bug/svg-circle-mask
• bug_fixes/Bug-1966
• bug_fixes/Bug-4770
• bugs/blurry-first-frame
• bugs/checkbox-no-refresh
• bugs/default-canvas-scale
• bugs/excessive-refresh
• bugs/fix-web-mobile-shader-compilation
• bugs/gopherjs-fix
• bugs/honor-goflags
• bugs/mimicking-go-build
• bugs/mobile-package-release
• bugs/propagate-tags-to-mobile-build
• calendar_additions
• canvas_optimization
• ci-updates2
• clang-ci-linux
• cleanup-closed-windows-inline
• cleanup-cmd-fyne
• cleanup-of-unneeded-locks
• cleanup/remove-unecessary
• clear-pending-ops-after-start
• cloud
• cmd-fyne-linux-package-gzip
• collections-thread-update
• colorforwidget
• colorize-svg
• compare-uri
• current-app-no-atomic
• demo-cleanup-queue
• demotabrefresh
• dependabot/go_modules/golang.org/x/net-0.17.0
• deprecate-cmd/fyne-again
• deps-upgrade
• desktop-cursor-and-key-cleanup
• develop
• disable-dpi-detection
• downgrage_opengl
• dweymouth-patch-1
• dynamic-array-size
• dynamic-cache-clean
• efficient-gridwrap-resize
• efficient-map-clear
• efficient-runloop
• efficient-split
• efficient-table-size-scroll
• efficient-tree
• embed-shaders
• embed-theme-contents
• empty-interface-to-any
• entry-overrides-too-much
• entry-refactory
• entry-undo-redo
• entry_icon
• equaluri-faster
• faster-gorutine-id
• feature/adaptive-grid
• feature/arc_canvas
• feature/bindpreferencelists
• feature/blur
• feature/borderlesswindow
• feature/borderside
• feature/clip
• feature/cloud
• feature/cursor
• feature/databinding
• feature/demo2
• feature/dialog
• feature/dialogtest
• feature/drag-and-drop
• feature/enforce-go-version
• feature/entry-disable
• feature/filedialog
• feature/filehandling
• feature/fyne-build-cmd
• feature/fynedoasync
• feature/gl-driver
• feature/graceful-failure-windows-gl
• feature/handle-dark-light-web-mode
• feature/imagecover
• feature/imagefromuri
• feature/invoke
• feature/jsonfallback
• feature/listbinding
• feature/mapbinding
• feature/menu
• feature/mobile_touches
• feature/mobilepreferences
• feature/multiline
• feature/navigation-container
• feature/negativegradient
• feature/notifications
• feature/openuri
• feature/overlay
• feature/package
• feature/pixelcoord
• feature/polygon_canvas
• feature/polygon_radius_max
• feature/rectangleaspect
• feature/rounded-images
• feature/scale_relative
• feature/scroller
• feature/scrolltextgrid
• feature/selectablelabel
• feature/selective_lang_loading
• feature/splash-screen-web-app
• feature/systraywindow
• feature/tamago
• feature/test-builtin-translations
• feature/text-selection
• feature/textgrid
• feature/textgrid2
• feature/textgridcoordinates
• feature/vendor_tool
• feature/web-driver-default
• feature/web-gopherjs-build_package_serve
• feature/web-openurl
• feature/web-storage-api
• feature/widget_inherit
• features/grey-font
• fix-5323
• fix-5358
• fix-5661
• fix-concurrent-map-write-crash
• fix-demo-races
• fix-expiringcache-race
• fix-go1.24-wasm_exec-path
• fix-mobile-simulator-compile
• fix-progressbar-before-refresh
• fix-render-leak
• fix-static-analysis
• fix-stick
• fix-typos
• fix-useless-test
• fix/1114
• fix/1861
• fix/1893
• fix/2184
• fix/2408
• fix/2411
• fix/2579
• fix/2588
• fix/2595
• fix/2627
• fix/2774
• fix/2784
• fix/3003
• fix/3046
• fix/3565
• fix/3752
• fix/4208
• fix/4312
• fix/4471
• fix/4568
• fix/5113
• fix/5141
• fix/5272
• fix/5281
• fix/5282
• fix/5307
• fix/5310
• fix/5313
• fix/5331
• fix/5362
• fix/5370
• fix/5393
• fix/5398
• fix/5401
• fix/5418
• fix/5430
• fix/5433
• fix/5454
• fix/5456
• fix/5463
• fix/5476
• fix/5478
• fix/5493
• fix/5535
• fix/5548
• fix/5564
• fix/5593
• fix/5606
• fix/5616
• fix/5619
• fix/5639
• fix/5640
• fix/5652
• fix/5653
• fix/566
• fix/5666
• fix/5671
• fix/5705
• fix/5714
• fix/5722
• fix/5724
• fix/5733
• fix/5745
• fix/5753
• fix/5766
• fix/5877
• fix/913
• fix/androidlocaleinit
• fix/appdatacrash
• fix/async-window-setup
• fix/cirace
• fix/customthemeperformance
• fix/databinddeadlock
• fix/datathread
• fix/demodeprecated
• fix/doubletapdelay
• fix/extendcontainer
• fix/fasterminsize
• fix/fontcachesafety
• fix/formspacing
• fix/fynedologline
• fix/gobuild
• fix/imagerefresh
• fix/iosfiles
• fix/mergethreads
• fix/mobilewebkeyboard
• fix/onclosedloop
• fix/overridepadding
• fix/polygonanglename
• fix/preflistoverwrite
• fix/preftest
• fix/racedetection
• fix/rectangle_inconsistent_borders
• fix/removefocusfunc
• fix/removesquarestruct
• fix/richtextrace
• fix/shadowalignment
• fix/smootherfynedotransition
• fix/splittappable
• fix/tableextendfocus
• fix/tabnamechange
• fix/textspeed1
• fix/threadwarningignore
• fix/unbreak-translations
• fix/windowhiddencontent
• fix/xdgthemefallback
• fix611
• fix_button_animation
• fix_fynedo_queue
• fix_table_scroll_reset
• fix_text_fields
• fix_textgrid_scroll_issue
• fix_tree_item_focus
• fixalign
• fixkeynames
• fixmobilegomod
• fixthemeoverwrite
• fixwindowsscale
• flatpak-dialog-races
• font-mutex
• fully_rounded_corner_radius
• fynedo-syncmap
• generic-binding-item
• generic-bindtrees
• generic-chan-cleanup
• generic-list-bindings
• gofumpt
• gofumpt-changes-fix
• gofumpt-ci
• gopls-fixes
• goxjs-to-wasm
• gridwrap-crash-before-renderer
• hayden-android-notification-icon
• hayden-async-data-listeners
• hkparker-add-entry-action-item-to-objects
• hkparker-change-dialog-callback-order
• hkparker-get-markdown-images-from-origin
• hotfix/165-repeat-typedkey
• image-round-corners
• image_minsize
• img-fully-rounded
• implementation-5590
• improvements/fix-coding-style
• improvements/gopherjs-goroutine-id
• infinite-animation
• josh/container-remove-no-copy
• js-fixes-and-refactors
• json_theme_optimize
• key_refactor
• keyboard-api
• label-style
• last-big-lock.cleanup
• latest-js-libs
• list_selection_fix
• lucor-patch-1
• mac-scroll-adjust
• mac-scrollbar-setting
• markdown_set_list_starting_index
• markup_renderer-lookup-optimize
• master
• menu_item_tappable
• menuitem-with-icon
• migrate-away-from-sync-once
• minor-base-widget-cleanup
• minor-dep-updates
• minor-tab-fixes
• mobile-simulator-compile
• mobile_improvements
• mobileclipboard
• moduke-update
• monitor-detection
• more-generic-bindings
• newapptabs-no-refresh
• nil-slices-are-fine
• no-time-func-per-cursor
• oksvg-modern
• oksvg-v0.2.0
• opengl_optimizations_for_gles
• overlay-stack-merge
• paniconbadstart
• patch-1
• portal-v0.4.1
• radius_max_constraint
• rectangle_edge_smoothness_fix
• rectangle_partially_rounded_corners
• rectangle_shadow
• refresh-queue-experiments
• refs/tags/v1.4.3
• refs/tags/v2.0.0
• refs/tags/v2.0.0-rc1
• refs/tags/v2.0.0-rc4
• refs/tags/v2.0.0-rc5
• refs/tags/v2.0.1
• refs/tags/v2.0.1-rc1
• refs/tags/v2.0.1-rc2
• refs/tags/v2.0.2
• refs/tags/v2.0.3
• refs/tags/v2.0.3-rc1
• refs/tags/v2.0.3-rc2
• refs/tags/v2.0.4
• refs/tags/v2.0.4-rc1
• refs/tags/v2.0.4-rc2
• refs/tags/v2.0.4-rc3
• refs/tags/v2.0.4-rc4
• refs/tags/v2.0.4-rc5
• refs/tags/v2.1.0
• refs/tags/v2.1.0-rc1
• refs/tags/v2.1.0-rc2
• refs/tags/v2.1.1
• refs/tags/v2.1.2
• refs/tags/v2.1.2-rc1
• refs/tags/v2.1.2-rc2
• refs/tags/v2.1.3
• refs/tags/v2.1.4
• refs/tags/v2.2.0
• refs/tags/v2.2.0-rc1
• refs/tags/v2.2.1
• refs/tags/v2.2.2
• refs/tags/v2.2.2-rc1
• refs/tags/v2.2.2-rc2
• refs/tags/v2.2.2-rc3
• refs/tags/v2.2.3
• refs/tags/v2.2.3-rc1
• refs/tags/v2.2.4
• refs/tags/v2.2.4-rc1
• refs/tags/v2.3.0
• refs/tags/v2.3.0-rc1
• refs/tags/v2.3.0-rc2
• refs/tags/v2.3.0-rc3
• refs/tags/v2.3.0-rc4
• refs/tags/v2.3.1
• refs/tags/v2.3.1-rc1
• refs/tags/v2.3.1-rc2
• refs/tags/v2.3.2
• refs/tags/v2.3.2-rc1
• refs/tags/v2.3.2-rc2
• refs/tags/v2.3.2-rc3
• refs/tags/v2.3.3
• refs/tags/v2.3.3-rc1
• refs/tags/v2.3.4
• refs/tags/v2.3.4-rc1
• refs/tags/v2.3.5
• refs/tags/v2.3.5-rc1
• refs/tags/v2.3.5-rc2
• refs/tags/v2.4.0
• refs/tags/v2.4.0-rc2
• refs/tags/v2.4.1
• refs/tags/v2.4.1-rc1
• refs/tags/v2.4.2
• refs/tags/v2.4.2-rc1
• refs/tags/v2.4.3
• refs/tags/v2.4.3-rc1
• refs/tags/v2.4.3-rc2
• refs/tags/v2.4.4
• refs/tags/v2.4.4-rc1
• refs/tags/v2.4.4-rc2
• refs/tags/v2.4.5
• refs/tags/v2.4.5-rc1
• refs/tags/v2.5.0
• refs/tags/v2.5.1
• refs/tags/v2.5.1-rc1
• refs/tags/v2.5.3
• refs/tags/v2.5.3-rc1
• refs/tags/v2.5.3-rc2
• refs/tags/v2.5.3-rc3
• refs/tags/v2.5.3-rc4
• refs/tags/v2.5.3-rc6
• refs/tags/v2.5.3-rc7
• refs/tags/v2.5.4
• refs/tags/v2.5.4-rc1
• refs/tags/v2.5.5
• refs/tags/v2.5.5-rc1
• refs/tags/v2.6.0
• refs/tags/v2.6.0-alpha1
• refs/tags/v2.6.0-beta1
• refs/tags/v2.6.0-rc1
• refs/tags/v2.6.0-rc2
• refs/tags/v2.6.1
• refs/tags/v2.6.2
• refs/tags/v2.6.2-rc1
• refs/tags/v2.6.3
• refs/tags/v2.6.3-rc1
• release/v1.0.0
• release/v1.2.1
• release/v1.2.2
• release/v1.2.3
• release/v1.2.4
• release/v1.3.0
• release/v1.3.3
• release/v1.3.x
• release/v1.4.x
• release/v2.0.x
• release/v2.1.x
• release/v2.2.x
• release/v2.3.x
• release/v2.4.x
• release/v2.5.x
• release/v2.6.x
• remove-binding-recover
• remove-concurrent-queue
• remove-extra-refresh
• remove-test-only-painterData
• remove.most-remaining-false-locking
• resizemodal2
• revert-5344-infinite-animation
• roffe/multiwindow
• run-tests-migrated
• scaling-fix
• secondary_windows_is_not_refreshed
• settings-callback
• setup-go-v6
• simpler-os-selection
• single-threaded-pool-buffer
• speedup-wasm-device-handling
• split-hidden
• stop-animations-when-switching-tutorial
• storage_repository
• suppress-loggerrors
• test-linting
• test-renderers
• testifylint
• textgrid_fix_setstylerange
• textgrid_remove_cache_renderer
• textgrid_remove_dead_code
• textgrid_scrolltotop
• textgridline
• theme-current-variant
• theme-load-improvements
• tilo_cruise
• unconvert
• update-go-locale-version
• update-renderer-clean
• update-renderer-doc-1
• uri-parse-ipv6-support
• uri-string-builders
• use-any-instead-of-empty-interface
• v1.0.0
• v1.0.1
• v1.2.0
• v1.2.0-beta1
• v1.2.0-beta2
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.3.0
• v1.3.1
• v1.3.2
• v1.3.3
• v1.4.0
• v1.4.0-rc1
• v1.4.0-rc2
• v2.6.0-deps-preparations
• validate
• walking_skeleton
• wasm-clipboard-optimization
• wasm-cursor-support
• wasm-driver-fixes
• wasm-mobile-lookup-cleanup
• weblate-fyne-fyne
• widget-nocopy
• widget_destroy
• windows-mobile-workaround

Build # 15954263484

Build Type

Pull #5817

github

Committed by Jacalz

Commit Message

Simplify a few size and position comparisons

There is no need to subtract and then check for zero.
Just comparing structs directly is cleaner and should generate a lot
more efficient code (unless the compiler already managed to optimize the
old code in the same way).

Pull Request Pull Request #5817: Simplify comparison of positions and sizes

Run Details

4 of 4 new or added lines in 3 files covered. (100.0%)

25163 of 40395 relevant lines covered (62.29%)

712.43 hits per line