funilrys / PyFunceble

97%

master: 97%

LAST BUILD ON BRANCH issue-435

branch: issue-435

CHANGE BRANCH

x

Reset

• issue-435
• 3.x
• 4.0.0-dev
• add-ua-ref
• allow-config-dir-overwrite-from-api
• allow-multiple-output-queues
• box-6
• chancy-tester
• col20
• collection-dev
• dev
• dns-recusion-depth
• ext-special-rules
• fix-migration
• issue-132
• issue-164
• issue-185
• issue-261
• issue-268
• issue-276
• issue-291
• issue-292
• issue-293
• issue-297
• issue-300
• issue-303
• issue-311
• issue-319
• issue-321
• issue-328
• issue-333
• issue-334
• issue-341
• issue-346
• issue-361
• issue-377
• issue-389
• issue-398
• maintenance
• master
• max-http-retries
• mtest
• new-proc-manager
• no-central-requester
• parked-subject
• postgresql-integration
• raw2sqlalchemy
• renovate/configure
• renovate/major-github-actions-deps
• renovate/major-pip-deps
• renovate/pip-deps
• rpz-syntax-check
• snyk-fix-829f437d05d09f3bfec04fc6f83ded83
• snyk-fix-b632daa1aefecdd5022b2f57ed12eede
• snyk-fix-bc6d6527db434ed0931bd007447c060f
• snyk-fix-c5b593325ea0afcad67099468612543c
• sqlalchemy-2.0
• switch-collection
• switch-to-mkdocs
• tests-with-no-connection
• windows-test

Build # 20530599664

Build Type

push

github

Committed by funilrys

Commit Message

Add a locking mechanism when accessing CSV files.

This patch touches #435.

Indeed, as discovered by @Yuki2718 and @DandelionSprout, our processes sometimes
trigger a PermissionError exception on Windows.

While testing with one of the latest builds of Windows 11 (Pro), I was able to
reproduce the issue sometimes and therefore analyze it in more detail. It turns out
that in some rare cases, 2 processes are simultaneously attempting to read the same
CSV file.

This patch attempts to solve the problem by introducing a shared lock which - for now
- only affect Windows-Users. When running on Windows, all processes will share a lock
that blocks when 2 processes try to access the same ressource at the same time.

Contributors:
  * @Yuki2718
  * @DandelionSprout

Run Details

28 of 30 new or added lines in 11 files covered. (93.33%)

11730 of 12147 relevant lines covered (96.57%)

11.57 hits per line