freedomofpress / fingerprint-securedrop

73%

master: %

LAST BUILD ON BRANCH simplify-group-membership-tasks

branch: simplify-group-membership-tasks

CHANGE BRANCH

x

Reset

• simplify-group-membership-tasks
• add-data-state-notebook
• add-eval-tests-to-travis
• crawler-systematic-crashing
• docs-rework
• enable-swap-for-torbrowser
• fix-travis-tests
• go-knn-integration
• hotfix-sorter-crawler
• libvirt-support-for-development
• logging-folder-permissions
• make-config-a-system-file
• master
• ml-classifiers
• populate-raw-schema-in-vm
• tbb-6.5
• templatize-config-ini
• travis-and-coveralls
• travis-idempotence
• turn-down-for-stem
• update-pip-reqs
• update-pip-requirements

Build # 310

Build Type

push

travis-ci

Committed by conorsch

Commit Message

Simplifies group membership update task

The original intent here is to add all authorized users to the `fpsd`
group so that developers can run commands as the `fpsd` service account
without directly su'ing as the service account user. Makes sense.

The previous implementation was using a two-pass approach to accommodate
for improper idempotence handling in Ansible's `user` module. Was able
to reproduce the issue reliably on Ansible v2.1.1, but Ansible v2.2.0
has resolved the issue, and the role applies cleanly on multiple runs
with the new one-task approach.

Run Details

8 of 11 relevant lines covered (72.73%)

0.73 hits per line