fredbi / uri

98%

master: 89%

LAST BUILD ON BRANCH fix-reduce-regexps

branch: fix-reduce-regexps

CHANGE BRANCH

x

Reset

Sync Branches

• fix-reduce-regexps
• build/resolve-go1.19-backwards-compat
• chore/ci-dependabot-update
• ci-govulncheck
• ci/fix-actions
• dependabot/github_actions/ci-actions-167a898cab
• dependabot/github_actions/ci-actions-8e42324b74
• dependabot/github_actions/ci-actions-a331d3ec2d
• dependabot/go_modules/development-dependencies-ddf553c9d0
• dependabot/go_modules/github.com/stretchr/testify-1.9.0
• doc-readme
• doc/readme-todos
• doc/readme-update
• doc/update-doc
• enh-error-handling
• exp/profile-with-bitset
• exp/switch-dns
• feat/default-port
• feat/explicit-errors
• feat/inner-error-state
• feat/more-iana
• feat/strict-ip
• feat/stricter-percent-decode
• feat/stricter-scheme
• fix-3-path-in-host-field
• fix/55
• fix/ci-stuff
• fix/doc
• fix/edgecases
• master
• patch-1
• perf/inner-pointer
• perf/profiling
• perf/slices-to-switch
• perf/string-allocs
• refact-layout
• refact-minor-optims
• refact-tests
• refact-validations
• refs/tags/v0.1.0
• refs/tags/v1.0.0
• refs/tags/v1.1.0
• refs/tags/v1.1.1
• release/prepare-v1.1.0
• test-fuzz
• test/more-coverage
• test/regroup-rationalize
• updated-docs
• v2
• workflow

Build # 6212459369

Build Type

Pull #20

github

Committed by fredbi

Commit Message

enhancement: replaces regular expressions by explicit parsing following
the RFC grammar.

Performance
-----------
* Removed all usage of regexp's.
* Replaced IPv6 parsing by standard lib functionality.

Overall, the benchmark shows a speed improvement of x5 when compared to
v0.1. This is still 2x slower than URL parsing with the standard libary.

RFC strictness
-----------
This PR fixes a few strictness issues:
* identifies wrong URIs with empty authority and path starting with a
double '/'
* identifies invalid IPv6 addresses with an empty zone
* strictier check of DNS names
* strictier check of URL-encoded escape sequences
* allow escape sequences in IP addresses
* strictly follows the RFC rule: "if not a valid IP, then consider a
registered name": hence
* strictier IP kind distinction: IPv6 must be between [], IPv4 must not

Caveats: IPv6 relies on the standard library and is therefore not very
strict regarding valid IPv6.

Fixes
-----------
* fixes #14

Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>

Pull Request Pull Request #20: enhancement: replaces regular expressions by explicit parsing following the RFC grammar.

Run Details

184 of 184 new or added lines in 1 file covered. (100.0%)

613 of 627 relevant lines covered (97.77%)

252.44 hits per line