fkhadra / react-toastify

85%

master: 91%

LAST BUILD ON BRANCH next-v11.1

branch: next-v11.1

CHANGE BRANCH

x

Reset

• next-v11.1
• BEM
• bugfixes
• css-classes-last
• custom-toast-id
• dependabot/npm_and_yarn/acorn-5.7.4
• dependabot/npm_and_yarn/ajv-6.12.6
• dependabot/npm_and_yarn/ejs-3.1.7
• dependabot/npm_and_yarn/eslint-utils-1.4.2
• dependabot/npm_and_yarn/example/acorn-5.7.4
• dependabot/npm_and_yarn/example/ajv-6.12.6
• dependabot/npm_and_yarn/example/browserslist-4.16.6
• dependabot/npm_and_yarn/example/color-string-1.6.0
• dependabot/npm_and_yarn/example/dot-prop-4.2.1
• dependabot/npm_and_yarn/example/elliptic-6.5.3
• dependabot/npm_and_yarn/example/elliptic-6.5.4
• dependabot/npm_and_yarn/example/json5-2.2.3
• dependabot/npm_and_yarn/example/lodash-4.17.19
• dependabot/npm_and_yarn/example/lodash-4.17.21
• dependabot/npm_and_yarn/example/minimist-1.2.6
• dependabot/npm_and_yarn/example/path-parse-1.0.7
• dependabot/npm_and_yarn/example/terser-5.14.2
• dependabot/npm_and_yarn/example/ws-5.2.3
• dependabot/npm_and_yarn/example/y18n-4.0.1
• dependabot/npm_and_yarn/glob-parent-5.1.2
• dependabot/npm_and_yarn/handlebars-4.5.3
• dependabot/npm_and_yarn/hosted-git-info-2.8.9
• dependabot/npm_and_yarn/json5-1.0.2
• dependabot/npm_and_yarn/loader-utils-3.2.1
• dependabot/npm_and_yarn/lodash-4.17.14
• dependabot/npm_and_yarn/lodash-4.17.21
• dependabot/npm_and_yarn/minimist-1.2.6
• dependabot/npm_and_yarn/mixin-deep-1.3.2
• dependabot/npm_and_yarn/path-parse-1.0.7
• dependabot/npm_and_yarn/playground/babel/traverse-7.23.7
• dependabot/npm_and_yarn/playground/postcss-8.4.33
• dependabot/npm_and_yarn/playground/vite-4.5.2
• dependabot/npm_and_yarn/playground/vite-4.5.3
• dependabot/npm_and_yarn/playground/vite-6.0.9
• dependabot/npm_and_yarn/playground/word-wrap-1.2.5
• dependabot/npm_and_yarn/postcss-7.0.36
• dependabot/npm_and_yarn/postcss-8.2.10
• dependabot/npm_and_yarn/postcss-8.2.13
• dependabot/npm_and_yarn/qs-6.5.3
• dependabot/npm_and_yarn/semver-6.3.1
• dependabot/npm_and_yarn/shelljs-0.8.5
• dependabot/npm_and_yarn/terser-5.14.2
• dependabot/npm_and_yarn/vite-5.0.12
• dependabot/npm_and_yarn/vite-5.0.13
• dependabot/npm_and_yarn/y18n-4.0.1
• develop
• ease-contribution
• feature/override-position
• feature/render-props
• fix
• fix-issue-103
• fix-issue-151
• fix-postcss-issue
• fix-travis
• issue-124
• issue-239
• main
• master
• move-to-github-actions
• next
• onClose-not-executed-
• progress-bar
• progressbar-style
• rc4
• refactor
• refs/tags/v10.0.0
• refs/tags/v10.0.1
• refs/tags/v10.0.2
• refs/tags/v10.0.2-debug
• refs/tags/v10.0.3
• refs/tags/v10.0.4
• refs/tags/v10.0.5
• refs/tags/v10.0.6
• refs/tags/v6.1.0
• refs/tags/v6.2.0
• refs/tags/v7.0.0
• refs/tags/v7.0.0-rc1
• refs/tags/v7.0.0-rc2
• refs/tags/v7.0.0-rc3
• refs/tags/v7.0.1
• refs/tags/v7.0.2
• refs/tags/v7.0.3
• refs/tags/v7.0.4
• refs/tags/v8.0.0
• refs/tags/v8.0.0-rc1
• refs/tags/v8.0.1
• refs/tags/v8.0.2
• refs/tags/v8.0.3
• refs/tags/v8.1.0
• refs/tags/v8.1.1
• refs/tags/v8.2.0
• refs/tags/v9.0.0
• refs/tags/v9.0.0-rc-1
• refs/tags/v9.0.0-rc-2
• refs/tags/v9.0.1
• refs/tags/v9.0.2
• refs/tags/v9.0.3
• refs/tags/v9.0.4
• refs/tags/v9.0.5
• refs/tags/v9.0.6
• refs/tags/v9.0.6-vite-1
• refs/tags/v9.0.7
• refs/tags/v9.0.8
• refs/tags/v9.1.0
• refs/tags/v9.1.1
• refs/tags/v9.1.2
• refs/tags/v9.1.3
• revert-babel-module
• rhdeck-master
• rsc-support
• rtl
• rtl-mobile
• sass-variable-rename
• sec-fix
• update-draggable
• update-node-version-for-travis
• v10
• v11
• v11.0.1
• v11.0.1-react17
• v11.0.2
• v11.0.3
• v11.1.0
• v2.1.6
• v2.1.7
• v2.1.8
• v2.2.0
• v2.2.1
• v2.2.2
• v3-beta
• v3.0.0
• v3.0.0-beta-1
• v3.1.0
• v3.1.1
• v3.1.2
• v3.2.1
• v3.3.3
• v3.3.4
• v3.3.5
• v3.4.0
• v3.4.1
• v3.4.2
• v4.0.0-rc.5
• v4.0.1
• v4.0.2
• v4.1.0
• v4.2.0
• v4.2.2
• v4.2.3
• v4.3.0
• v4.3.1
• v4.3.2
• v4.4.0
• v4.4.1
• v4.4.2
• v4.4.3
• v4.5.0
• v4.5.0-rc.1
• v4.5.1
• v4.5.2
• v5.0.0
• v5.0.0-rc.1
• v5.0.0-rc.2
• v5.0.0-rc.3
• v5.0.0-rc.4
• v5.0.0-rc.5
• v5.0.0-rc.6
• v5.0.1
• v5.0.1-rc.1
• v5.1.0
• v5.1.1
• v5.2.0
• v5.2.1
• v5.3.0
• v5.3.1
• v5.3.2
• v5.4.0
• v5.4.1
• v5.5.0
• v6
• v6.0.0
• v6.0.0-rc.0
• v6.0.0-rc.1
• v6.0.0-rc.3
• v6.0.1
• v6.0.1-rc.0
• v6.0.2
• v6.0.3
• v6.0.4
• v6.0.5
• v6.0.6
• v6.0.8
• v6.0.9

Build # 24632288719

Build Type

Pull #1285

github

Committed by fkhadra

Commit Message

fix: add unit to --y CSS variable to fix vertical drag

`--y` is initialized as `0` (unitless), which works in bare
`translate3d(0, var(--y), 0)` contexts. However, when
`draggableDirection` is `'y'`, the drag handler builds
`calc(${delta}px + var(--y))` — and `calc()` requires compatible
units on both operands. `calc(50px + 0)` is invalid CSS, while
`calc(50px + 0px)` is valid.

This causes vertical drag to have no visible effect — the toast
fades via opacity but doesn't move, because the transform is
silently invalid.

Changing `--y: 0` to `--y: 0px` fixes vertical dragging with no
impact on existing behavior, since `0` and `0px` are identical
in all non-calc contexts.

Pull Request Pull Request #1285: Next v11.1

Coverage Stats

218 of 276 branches covered (78.99%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 4 files covered. (100.0%)

341 of 382 relevant lines covered (89.27%)

730.01 hits per line