firebase / angularfire

93%

master: 94%

LAST BUILD ON BRANCH kato-617

branch: kato-617

CHANGE BRANCH

x

Reset

• kato-617
• 2.0
• ah-docs
• cleanup-kato
• de-docs
• de-provider
• docs-ref
• firebaseauth-init-fix
• fix510
• fix510-deux
• jw-082
• jw-091-prep
• jw-200-changelog
• jw-201-changelog
• jw-add-version-numbers-to-json-files
• jw-auth-creds
• jw-auth-fixes
• jw-auth-updates
• jw-change-email
• jw-change-log-1-1-0
• jw-changelog
• jw-changelog-1-1-1
• jw-coveralls
• jw-create-user-uid
• jw-credentials-typo
• jw-database-typos
• jw-e2e-reliability
• jw-error-message-typo
• jw-error-on-array
• jw-firebase-2-x-x
• jw-firebase-dep
• jw-fix-firebaseAuth-promises
• jw-fix-package-json
• jw-fix-travis-tests
• jw-getKey-rename
• jw-github-templates
• jw-google-groups-link
• jw-jasmine
• jw-key-polyfill
• jw-linter-error
• jw-login-v2
• jw-logout-bug
• jw-logout-fix-2
• jw-npm
• jw-npm-license-field
• jw-readme
• jw-readme-upgrades
• jw-release-notes-2-3-0
• jw-sauce
• jw-sauce-tag
• jw-signOut-promise
• jw-signin-docs-fixes
• jw-travis-upgrades
• jw-try-catch
• jw-update-README
• jw-update-deps
• jw-update-google-group
• jw-update-readme
• jw-update-script-tags
• jw-update-signOut-docs
• jw-utils-cleanup
• jw-version-2-2-0
• jw-version-number
• jw-watch-docs
• kato-1.4
• kato-400
• kato-403
• kato-527
• kato-_getKey
• kato-changelog
• kato-datejson
• kato-error
• kato-evalasync
• kato-extendArrayFactory
• kato-extendFactory
• kato-indexfor
• kato-log
• kato-merge
• kato-newkeyword
• kato-protractor
• kato-removefb
• kato-rename
• kato-resolve
• katowulf-af2-readme
• master
• modulefire
• readme_updates
• release_0.8.1
• revert-656-drop-bower
• storage
• storage-docs
• test-improvements
• update-ng-version
• v0.8.1
• v0.8.2
• v0.9.0
• v0.9.1
• v0.9.2
• v1.0.0
• v1.1.0
• v1.1.1
• v1.1.2
• v1.1.3
• v1.1.4
• v1.2.0
• v2.0.0
• v2.0.1
• v2.0.2

Build # 831

Build Type

push

travis-ci

Committed by katowulf

Commit Message

Fixes #617 - $loaded() triggered too soon

Because of promisifying the $$added method, the child_added events were actually being processed internally after the loaded trigger. This occurred because $q.when() actually uses nextTick() internally as well, meaning the child_added events occurred immediately, but then $$process was not called until the second tick occurred; a difficult use case to catch.

The $loaded() event, meanwhile, had already triggered on the first tick. Solution was to promisify all the events and then remove the batch() wrapper since they trigger on nextTick() anyway now. So all events are back to firing in order on the next tick.

Run Details

18 of 18 new or added lines in 2 files covered. (100.0%)

622 of 671 relevant lines covered (92.7%)

119.5 hits per line