fhunleth / muontrap

86%

main: 86%

LAST BUILD ON BRANCH remove-task-async

branch: remove-task-async

CHANGE BRANCH

x

Reset

• remove-task-async
• bump-deps
• chunk/fix-daemon-metadata-test
• ci-macos
• ci-ubuntu
• delay-to-sigkill-fix
• do-not-merge-cgroup-v2
• errors-restart
• fh-fix-epipe-exits
• fix-doc-headers
• fix-test-ubuntu-26.04
• hexdoc-url
• log_prefix
• logger_rc
• main
• master
• misc-cleanup
• misc-cleanup-for-pr
• misc_fixes
• more-cgroups
• parallel_make
• port-abnormal-exit
• rel-v0.5.0
• rel-v0.5.1
• rel-v0.6.0
• rel-v2.0.0
• rel-v2.0.0-rc.0
• rel-v2.0.0-rc.1
• rel-v2.0.1
• reminder
• remove-delay-to-sigkill-max-limit
• signal-exit
• sync-contributing-cd6ee8b3fe
• sync-contributing-d7b0b62bbf
• sync-readme-badges-407added84
• test-elixir-1.20
• v0.5.0
• v0.5.0-rc.0
• v0.5.1
• v0.6.0

Build # 10d9bb45-f5c3-4483-b851-517a2bc9db6b

Build Type

Pull #113

circleci

Committed by fhunleth

Commit Message

Fix Argus warning by simplifying Task.async

This fixes:

```
warning[argus.mailbox]: Async task never awaited
    ╭─[lib/muontrap/daemon.ex:270:7]
    │
268 │     case Map.get(options, :wait_for) do
269 │       nil -> {:ok, start_port(state)}
270 │       fun -> {:ok, %{state | wait_task: Task.async(fun)}}
    •       ─────────────────────────┬─────────────────────────
    •                                ╰── task started here
271 │     end
272 │   end
    │
    ╰─────
      note: MuonTrap.Daemon.init/1 starts a task with Task.async (or async_nolink) but nothing awaits or yields it. Task.async links to the caller and always sends a result message: a crashing task takes the caller down, and completed results accumulate unread in the mailbox.
      help: consume the result with `Task.await/2` (or `Task.yield/2` plus `Task.shutdown/1`), or use `Task.Supervisor.start_child/2` for fire-and-forget work
```

We only need to know when the process is done, so this saves cleaning up
the mailbox while still propogating a crash if that happens.

Pull Request Pull Request #113: Fix Argus warning by simplifying Task.async

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

246 of 285 relevant lines covered (86.32%)

1722.55 hits per line