farsightsec / fstrm

73%

master: 73%

LAST BUILD ON BRANCH branches/rotate-output

branch: branches/rotate-output

CHANGE BRANCH

x

Reset

• branches/rotate-output
• branches/issue34
• branches/osx
• branches/travis
• master
• next
• v0.2.0
• v0.3.0
• v0.3.1
• v0.3.2

Build # 59

Build Type

push

travis-ci

Committed by edmonds

Commit Message

Various changes for output rotation

Some various cleanups and refactoring of Sami's commits, in particular:

- Require explicitly requesting strftime() filtering of the -w argument,
  via either --localtime or --gmtime. This allows a choice of local
  timezone or UTC timestamps.

- Factor out the strftime() rewriting code from open_write_file() into
  a new function update_output_fname().

- Factor out the file rotation code from cb_read() into a new function
  maybe_rotate_output().

- Remove the arbitrary 1024-byte limit on filenames. (Though, add a
  256-byte arbitrary limit on the expansion of the strftime() format
  specifier, since there doesn't appear to be a way to obtain that size
  in advance.)

- Remove the filename suffix appending feature. I'm not sure this is
  entirely necessary. (But if it is it should probably be done via a
  separate patch.)

Run Details

845 of 1157 relevant lines covered (73.03%)

308052.4 hits per line