ethereum / go-ethereum

49%

master: 36%

LAST BUILD ON BRANCH fix-discover-hangs

branch: fix-discover-hangs

CHANGE BRANCH

x

Reset

• fix-discover-hangs
• 0.9.16
• 0.9.23
• appveyor
• canaryFix
• core-optimisations
• develop
• fix-js-console-windows
• fix-tests-windows
• gpuminer
• hard-disconnect-trial
• logjson
• master
• poc8
• qt5.4
• release/0.9.36
• release/1.0.0
• release/1.0.1
• revert-1354-gasprice
• revert-781-develop
• revert-785-revert-781-develop
• revert-793-discovery-node-cache
• rpcfrontier
• tests
• travis
• v0.8.4
• v0.8.4-1
• v0.9.17
• v0.9.18
• v0.9.20
• v0.9.21
• v0.9.21.1
• v0.9.23
• v0.9.24
• v0.9.25
• v0.9.26
• v0.9.30
• v0.9.32
• v0.9.34
• v0.9.34-1
• v0.9.36
• v0.9.39
• v1.0.0
• v1.0.1
• v1.0.1.1
• v1.0.1.2
• v1.0.2
• v1.0.3
• v1.0.4
• v1.0.5
• vitalik_quick_test

Build # 3889

Build Type

push

travis-ci

Committed by fjl

Commit Message

p2p/discover: fix UDP reply packet timeout handling

If the timeout fired (even just nanoseconds) before the deadline of the
next pending reply, the timer was not rescheduled. The timer would've
been rescheduled anyway once the next packet was sent, but there were
cases where no next packet could ever be sent due to the locking issue
fixed in the previous commit.

As timing-related bugs go, this issue had been present for a long time
and I could never reproduce it. The test added in this commit did
reproduce the issue on about one out of 15 runs.

Run Details

10410 of 21362 relevant lines covered (48.73%)

5633.54 hits per line