esnet-security / SCRAM
93%
develop: 94%

LAST BUILD BRANCH: topic/soehlert/read_only_blocked
DEFAULT BRANCH: develop
Repo Added
Files 47
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH topic/soehlert/duplicate_history_entries
branch: topic/soehlert/duplicate_history_entries
CHANGE BRANCH
x

coverage: 92.894% (-2.1%) from 95.03%
18979172634

Pull #163

github

soehlert 
test(restrict_changes): set this back to a 405 error

i think we do want to fail on the method, not on the user permissions. doing a 403 suggests that sometimes you can change an entry, but we always want to block PUT/PATCH as the client should just do a normal post every time and SCRAM handles the logic on our end. We don't want the client to have to track these things.
Pull Request #163: fix(history): Remove duplicate history objects for entries

60 of 65 branches covered (92.31%)

Branch coverage included in aggregate %.

45 of 57 new or added lines in 3 files covered. (78.95%)

20 existing lines in 2 files now uncovered.

1208 of 1300 relevant lines covered (92.92%)

0.93 hits per line

Relevant lines Covered
1300 RELEVANT LINES 1208 COVERED LINES
0.93 HITS PER LINE
Source Files on topic/soehlert/duplicate_history_entries

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
18979172634 topic/soehlert/duplicate_history_entries test(restrict_changes): set this back to a 405 error i think we do want to fail on the method, not on the user permissions. doing a 403 suggests that sometimes you can change an entry, but we always want to block PUT/PATCH as the client should ju... Pull #163 soehlert github
92.89
18688689000 topic/soehlert/duplicate_history_entries Merge branch 'main' into topic/soehlert/duplicate_history_entries * main: ci: remove test that doesn't work on GH Actions (#170) fix(typo): use the correct key feat(gw_priority): this should allow us to choose which network is the "default ... Pull #163 soehlert github
93.47
18688690504 topic/soehlert/duplicate_history_entries Merge ed8786453 into b06fe12d8 Pull #163 web-flow github
93.47
16197656617 topic/soehlert/duplicate_history_entries style(route action): remove extraneous code. we already have gotten the route and actiontype in the view and passed it to the serializer Pull #163 samoehlert github
95.01
16180226078 topic/soehlert/duplicate_history_entries style(ruff): run ruff formatting and rule checking Pull #163 samoehlert github
95.02
16176900137 topic/soehlert/duplicate_history_entries test(update comment): make sure we actually can test the comment update and create a helper for our client to easily get to hostname as the who Pull #163 samoehlert github
94.89
See All Builds (377)