esl / MongooseIM

85%

master: 86%

LAST BUILD ON BRANCH carboncopy-flaky-test

branch: carboncopy-flaky-test

CHANGE BRANCH

x

Reset

• carboncopy-flaky-test
• 2.0.0
• 2.0.0_mam_metrics
• 2.0.0beta1
• 2.0.1
• 2.0.1-links
• 2.1.0
• 2.1.0alpha1
• 2.1.0alpha10
• 2.1.0alpha2
• 2.1.0alpha3
• 2.1.0alpha4
• 2.1.0alpha6
• 2.1.0alpha7
• 2.1.0alpha8
• 2.1.0alpha9
• 2.1.0beta1
• 2.1.0beta2
• 2.1.1
• 2.2.0
• 2.2.1
• 2.2.2
• 3.0.1
• 3.1.0
• 3.1.1
• 3.2.0
• 3.3.0
• 3.3.0-dummy-auth
• 3.4.0
• 3.4.1
• GH-actions-fix
• GH-actions-fix-rel-6.0
• Try-to-stabilize-rooms-for-rosters
• big_tests/amqp_client-3.9.1
• big_tests/base16-2.0.0
• big_tests/esip.1.0.43
• big_tests/remove-erlsh
• big_tests/remove-gen_fsm_compat
• big_tests/shotgun-0.5.0
• dashboardtest
• dependencies/cowboy_swagger-2.2.2
• deps/escalus-4.2.3
• deps/gun-1.3.3
• deps/jiffy-1.0.8
• deps/mongoose_jid-1.0.0
• deps/remove-ibrowse
• deps/remove-non-use-chatterbox
• deps/remove-rebar_faster_deps
• develop
• drop_centos
• erlang-28
• exp/escalus-gun-2
• fix-failing-s2s-tests
• fix-gh-actions
• fix-gh-actions-tests
• fix-readme-project-status
• fix/mongoose_metrics_hooks
• fix/run_undefined_host_type
• fix/system_metrics_error
• fixing-global-distrib-suite
• fixing-global-distrib-suite-rel-6.1
• fixing-reporting-to-ga4
• gdpr-remove-vcard
• gdpr-retrieve-clean
• imporve-coveralls-reporting
• mam/iq_fin_transformations
• master
• mu-scope-host
• readme-update
• readme-update-rel-6.1
• rebar3/3.15.2
• refactoring/otp-24.0.2
• refactoring/remove-travis-prefix
• refactoring/simplify-inet_stats
• refactoring/xref
• rel-1.7
• rel-2.0
• rel-2.1
• rel-2.2
• rel-3.0
• rel-3.1
• rel-3.2
• rel-3.3
• rel-3.4
• rel-6.0
• rel-6.1
• rel-6.2
• rel-6.3
• rel-6.4
• reporting-to-ga4
• safe-gh-actions
• stable
• update-OTP-version-for-GH-Actions
• update-gh-actions-versions

Build # 12318614146

Build Type

Pull #4437

github

Committed by gustawlippa

Commit Message

Unflake the test

Unfortunately, the underlying race condition is a bit tricky to fix elegantly.

`mod_carboncopy:remove_connection` is a handler for the `unset_presence` hook,
and it removes CC state from the ejabberd_sm info field in the session record.
This is however done in an async manner by the C2S process, and when the user
terminates, the request is never handled. This doesn't matter much, as the user
process exits shortly, and is removed from ejabberd_sm altogether. However, if
it receives a message in this short time, CC might run, and see the process
still with the CC state in the ejabberd_sm info field. This results in a CC copy
sent on behalf of this exiting process. Since a fix would be overly complicated,
and to proceed with unflaking the tests, the test will now wait for C2S process
exit.

Pull Request Pull Request #4437: Unflake the`dropped_client_doesnt_create_duplicate_carbons` test

Run Details

28797 of 33845 relevant lines covered (85.08%)

48718.31 hits per line