eserte / Doit

72%

master: 72%

push

github

Fix deadlock in open3 by using non-blocking reads

The open3 implementation could deadlock when the child process produces a large amount of output on both stdout and stderr.

This change fixes the issue by making the filehandles for stdout and stderr non-blocking and updating the read loop to handle non-blocking reads. The Fcntl constants are now correctly called as functions.

A test case has been added to reproduce the deadlock and verify the fix.

2 of 2 new or added lines in 1 file covered. (100.0%)

1791 of 2486 relevant lines covered (72.04%)

29.01 hits per line