erikhuda / thor

92%

master: 95%

LAST BUILD ON BRANCH fix-disable_class_options

branch: fix-disable_class_options

CHANGE BRANCH

x

Reset

• fix-disable_class_options
• check_default_type
• debug-config
• fix-build
• master
• test-did-you-mean-not-available
• v0.19.0
• v0.19.1
• v0.19.2
• v0.19.3
• v0.19.4
• v0.20.0
• v0.20.1
• v0.20.2
• v0.20.3
• v1.0.0
• v1.0.1

Build # 285

Build Type

push

travis-ci

Committed by rafaelfranca

Commit Message

Add disable_required_check! and make disable the check in help

In Thor 0.19.2 it was added a new class method disable_class_options.
It was added to disable the check for required options in the help
command. This new method disabled the option parser for help, so it is
not possible to pass option to that command anymore.

That change introduced a regression and it is fixing the problem at the
wrong level. What we want is to disable the required check not the
option parsing.

So, we reverted the disable_class_options change and added a new method
disable_required_check! to disable the required check in the commands we
want.

Theoretically this is a breaking change but the disable_class_options
introduction was also a breaking change so it is better to revert it and
fix the problem at the correct place.

Related with #462 and #363.

Run Details

19 of 19 new or added lines in 4 files covered. (100.0%)

2040 of 2217 relevant lines covered (92.02%)

466.84 hits per line