emitter-io / emitter

93%

master: 92%

LAST BUILD ON BRANCH response_size_limitation

branch: response_size_limitation

CHANGE BRANCH

x

Reset

• response_size_limitation
• (HEAD detached at 2b188eb)
• HEAD
• ___old___history_api
• bump-go-ver
• bump_appveyor_go
• bump_go_ver_1.20
• bump_go_ver_workflows
• bump_ver_all_deps
• bv3
• chore_update_deps
• chore_upgrading_dependencies
• cli_keygen
• crdt
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.34.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.11.1
• dependabot/go_modules/github.com/valyala/fasthttp-1.34.0
• dependabot/go_modules/go_modules-c153b83258
• dependabot/go_modules/golang.org/x/crypto-0.1.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/golang.org/x/sys-0.1.0
• dependabot/go_modules/golang.org/x/text-0.3.8
• deps
• fix-presence-on-extension-keys
• fix-track-atomicity
• fix_history_payload
• fix_keyban
• fix_storage_implement_surveyee
• fix_storage_surveyee
• gossip
• history_api
• ipv6
• keyban
• lock
• master
• more_history_tests
• msg_size_limiter
• presence
• quick_fix_memory_provider
• refactor
• refs/tags/v2.8
• refs/tags/v3.0
• refs/tags/v3.1
• shuffle
• status_field_to_all_responses
• sub-once
• survey
• test-workflow
• update_test_workflow
• val
• will

Build # 6923246233

Build Type

Pull #413

github

Committed by Florimond

Commit Message

Limit the size of a response

From the begining, mqtt.go defines a maximum size for a response.
However if the limit was met, it resulted in an error and no message was
sent. Now, the Query itself limits the size of a frame and messages are
sent to the client, but only those whose total size <= to the total size
of allowed in a response.

Implications on the current API: for a subscribe request with a Last=X
parameter, the client will receive the last messages whose total size is <= to
the max size of a response, with a maximum of X messages. This behavior is an
improvement over just getting an error.

Pull Request Pull Request #413: Limit the size of a response

Run Details

10 of 11 new or added lines in 2 files covered. (90.91%)

5369 of 5767 relevant lines covered (93.1%)

8122.51 hits per line