elixir-gettext / gettext

94%

main: 94%

LAST BUILD ON BRANCH avoid-duplicate-pot-read

branch: avoid-duplicate-pot-read

CHANGE BRANCH

x

Reset

Sync Branches

• avoid-duplicate-pot-read
• abdelhalim97/add-put_locale!
• al/1.18
• al/ci
• al/deprecate-plural-forms
• al/expo-plural
• al/new-backend-docs
• al/no-recompilation
• al/refactor
• al/release
• al/use-gettext-backend
• backend-static-translations
• bound-gettext-merge-concurrency
• cache-interpolation-patterns
• ci-bump-elixir-1.19-otp-28
• code-coverage
• dependabot/github_actions/actions/checkout-5.0.0
• dependabot/github_actions/actions/checkout-6.0.0
• dependabot/github_actions/actions/checkout-6.0.1
• dependabot/github_actions/actions/checkout-6.0.2
• dependabot/github_actions/actions/checkout-6.0.3
• dependabot/github_actions/actions/checkout-7.0.0
• dependabot/github_actions/actions/checkout-7.0.1
• dependabot/github_actions/erlef/setup-beam-1.20.2
• dependabot/github_actions/erlef/setup-beam-1.20.4
• dependabot/github_actions/erlef/setup-beam-1.21.0
• dependabot/github_actions/erlef/setup-beam-1.24.0
• dependabot/github_actions/erlef/setup-beam-1.24.1
• deprecation_message
• extract-from-attributes
• extract_force_compile
• extraction-merge-perf
• fix-concatenation-of-sigils
• fix-literal-braces-before-binding
• fix-nofile
• fix-typos
• fix/elixir-1.20-warnings
• fix/extract-timeout
• improve-docs
• indexed-merge-template
• introduce_initial_top_comments_via_messages_struct
• jm/ci_deps_check_locked
• jm/conflicting_plural_message_400
• jm/default_header
• jm/deps-update
• jm/dialyzer-setup
• jm/extend_plural_interface
• jm/extract_merge_always
• jm/flaky_test_mix_cache
• jm/gh-workflow-updates
• jm/legalese
• jm/mention-igniter-changelog
• jm/metadata-stripping
• jm/plural_mod_function_fix
• jm/release/v0.23.2
• jm/singular_plural_uniq
• jv-erase-manifest-unless-on-upcoming-elixir
• jv-fix-redefining
• keep_custom_flags_option
• main
• msg_sort_iodata
• on-missing-translation
• parallel-locale-merge
• plural-info-once
• previous_messages
• prune-fuzzy-candidates
• refs/pull/376/merge
• release/v0.22.2
• release/v0.27.0
• runtime-gettext
• sort_by_msgid_case_insensitive
• test_up_to_date
• tiny_fix
• wait-for-gettext-merge

Build # d5b8fa71d654859090471782193138d1cff7629c-PR-448

Build Type

Pull #448

github

Committed by oliver-kriska

Commit Message

Avoid reading each existing POT file twice during extraction

`read_contents_and_parse/1` read the file with `File.read!/1` and then called
`PO.parse_file!/2`, which reads the very same file again internally. Pass the
contents we already have to `PO.parse_string!/2` instead.

`PO.parse_file!(path, file: path)` is defined as `File.read` followed by
`parse_string(contents, file: path)`, so the parsed result is identical; the
existing `File.read!/1` still raises on a missing file. This removes one disk
read per existing POT file on every `mix gettext.extract`.

Pull Request Pull Request #448: Avoid reading each existing POT file twice during extraction

Coverage Stats

767 of 818 relevant lines covered (93.77%)

36.51 hits per line