edx / frontend-auth

100%

master: 100%

LAST BUILD ON BRANCH djoy/promise-ify-ensure-methods

branch: djoy/promise-ify-ensure-methods

CHANGE BRANCH

x

Reset

• djoy/promise-ify-ensure-methods
• abutterworth/403-do-not-logout
• abutterworth/add-token-logging
• abutterworth/add-token-refresh-failure-callback
• abutterworth/anonymous-access-refactor
• abutterworth/csrf
• abutterworth/fix-arch-687
• abutterworth/frontend-build
• abutterworth/refactor-access-token
• abutterworth/refactor-queuing
• abutterworth/upgrade-build
• abutterworth/upgrade-node
• ammar/export-logging-utils
• ddumesnil/admin-in-auth
• djoy/export_more_actions
• djoy/factor_out_saving_actions
• djoy/loaded_flag
• djoy/transpile_es6_node_modules
• djoy/update_readme_with_example
• djoy/webpack_mode
• douglashall/ARCH-653
• douglashall/ARCH-711
• douglashall/ARCH-840
• douglashall/ARCH-873
• douglashall/add_user_profile_fields
• douglashall/csrf
• douglashall/explicit_jwt_cookie_auth
• douglashall/fix_auth_interceptor
• douglashall/fix_private_route
• douglashall/fix_redirect_loop
• douglashall/npm_publish
• douglashall/peer_dependencies
• douglashall/user_profile
• douglashall/verify_access_token_expiration
• iahmad/ENT-1805-Authentication-for-frontend-learner-app
• master
• mikix/redirect-path
• mushtaq/403-do-not-logout
• renovate/axios-0.x
• renovate/axios-mock-adapter-1.x
• renovate/camelcase-keys-6.x
• renovate/commitlint-monorepo
• renovate/configure
• renovate/coveralls-3.x
• renovate/edx-frontend-logging-3.x
• renovate/enzyme-3.x
• renovate/enzyme-adapter-react-16-1.x
• renovate/eslint-6.x
• renovate/husky-3.x
• renovate/major-commitlint-monorepo
• renovate/major-reactrouter-monorepo
• renovate/npm-axios-vulnerability
• renovate/pin-dependencies
• renovate/prop-types-15.x
• renovate/react-monorepo
• renovate/redux-4.x
• renovate/semantic-release-monorepo
• renovate/uglifyjs-webpack-plugin-2.x
• renovate/webpack-4.x
• renovate/webpack-cli-3.x
• robrap/ARCH-379-get-user-id
• robrap/ARCH-687-update-logging
• robrap/ARCH-948-alternate-read-cookies
• robrap/ARCH-948-clean-up
• robrap/ARCH-948-fix-ensure-authentication
• robrap/ARCH-948-more-refresh-token-changes
• robrap/add-comment-1
• robrap/add-comment-2
• robrap/update-tests
• robrap/v1.3.2-es-check
• tuchfarber/make_ssr_friendly
• tuchfarber/update_ssr_friendly_logging
• v1.0.0
• v1.0.1
• v1.0.2
• v1.0.3
• v1.1.0
• v1.2.0
• v1.2.1
• v1.3.0
• v1.3.1
• v1.3.2
• v2.0.0
• v3.0.0
• v3.0.2
• v3.0.3
• v3.1.0
• v3.2.0
• v4.0.0
• v5.0.0
• v5.1.0
• v5.1.1
• v5.1.2
• v5.1.3
• v5.2.0
• v5.3.0
• v5.3.1
• v5.3.2
• v5.3.3
• v5.3.4
• v5.3.5
• v6.0.0
• v6.0.1
• v6.0.2
• v7.0.0
• v7.0.1
• v8.0.0
• v9.0.0

Build # 379

Build Type

Pull #61

travis-ci

Committed by web-flow

Commit Message

refactor(promises): consistently return promises from ensure methods

BREAKING CHANGE: Making the callback optional and deprecated.  Promises are the preferred way of waiting for the methods to finish.  Breaking change because it technically changes the method return value signature.  No known repositories are using the return value, luckily.

Also updating eslint-related packages so that the linter will stop complaining about object rest/spread issues.

Pull Request Pull Request #61: refactor(promises): consistently return promises from ensure methods

Run Details

57 of 57 branches covered (100.0%)

Branch coverage included in aggregate %.

27 of 27 new or added lines in 1 file covered. (100.0%)

173 of 173 relevant lines covered (100.0%)

3.0 hits per line