edx / edx-tim

90%

master: 92%

LAST BUILD ON BRANCH ormsbee/integrity_err

branch: ormsbee/integrity_err

CHANGE BRANCH

x

Reset

• ormsbee/integrity_err
• dave/stateful_workbench
• jrbl/231-feedback-on-assessments
• jrbl/bugfix_helpfulness
• master
• ormsbee/btalbs_xblock_wb_fix
• ormsbee/cache_sub
• ormsbee/cleanup_workflow
• ormsbee/copy_changes
• ormsbee/debug_toolbar
• ormsbee/django_toolbar_settings_fix
• ormsbee/kill_queries
• ormsbee/migrations
• ormsbee/no_verticals
• ormsbee/workflow2
• sanchez/TIM-168-Workflow-UI
• sanchez/TIM-191-Grade-UI
• sanchez/TIM-228-Peer-Workflow
• sanchez/TIM-277-track-scored-assessments
• sanchez/TIM-326-Due-Dates
• sanchez/bug-peer-submissions
• sanchez/fix-fixtures
• sanchez/fix-grading-incomplete-status
• sanchez/fix-max-score
• sanchez/fix-over-grading
• sanchez/fix-workflow-api-calls
• sanchez/overgrade-only-after-deadline
• sanchez/peer-workflow-model-update
• sanchez/quick-ui-fixes
• sanchez/render_security
• sanchez/turbo-mode-peer-grading
• sanchez/ui-cleanup
• sanchez/we-need-stinkin-badges
• talbs/cleanup-sass
• talbs/copy-gradereport
• talbs/copy-intromessage
• talbs/fed-cleanup
• talbs/fix-neat-sass-import
• talbs/fix-ui-topbar
• talbs/fix-uimisc
• talbs/fix-workbench-chrome
• talbs/remove-fontawesome
• talbs/styling-peerassessment
• talbs/styling-problem
• talbs/styling-selfassessment
• talbs/template-turbowaiter
• talbs/ui-assessment-feedback
• talbs/ui-cleanup
• talbs/ui-gradestatus
• talbs/ui-lmsproofing
• talbs/ui-messages
• talbs/ui-peerscores
• talbs/ui-scroll
• talbs/ui-studioproofing
• talbs/ui-tooltips
• talbs/ui-transitions
• will/TIM-367
• will/TIM-367-rebase
• will/additional-feedback-wording
• will/anonymize-student-ids
• will/check-node-installation
• will/cleanup-leftover-file
• will/concurrency-test
• will/coveralls-integration
• will/date-field
• will/deadlines
• will/deadlock
• will/dummy-db-data
• will/error-message-ui
• will/exclude-design-js-from-tests
• will/export-xml
• will/fix-coveralls-link
• will/fix-grade-collapse
• will/fix-js-submission-uuid-firefox
• will/fix-manifest
• will/fix-scenario-format
• will/fix-self-api-test
• will/fix-studio-preview-warning
• will/fix-test-failure
• will/ignore-ssl-perf-test
• will/js-cleanup
• will/js-debug-test
• will/js-expansion
• will/js-refactor
• will/limit-subquery-fix
• will/line-breaks
• will/log-submission-errors
• will/management-cmd
• will/metadata-editor-template
• will/minimize
• will/more-test-cleanup
• will/no-xml-in-studio-errors
• will/non-text-submission
• will/numeric-student-id
• will/ordering-comment
• will/peer-enable-disable-button
• will/perf-doc-update
• will/preserve-edits
• will/pylintrc
• will/remove-todo
• will/rename-tim
• will/revert-management-cmd
• will/rubric-criterion-modified
• will/save-ui-tweaks
• will/score-integrity-error
• will/score-integrity-error-test
• will/score-integrity-error-test-2
• will/self-assessment-api
• will/self-assessment-workflow
• will/stop-waiting-for-grade
• will/studio-integration-full
• will/studio-view-tests
• will/test-cleanup
• will/tim-230
• will/tim-258
• will/tim-71
• will/tim-86
• will/tim-fixtures
• will/unlink-assessment-from-submission
• will/update-create-submission-json
• will/update-fixtures-answer
• will/update-scenario-xml
• will/update-xblock-permissive

Build # 1230

Build Type

push

travis-ci

Committed by ormsbee

Commit Message

Fix integrity error on submission under repeatable-read mode.

Shift the creation of the peer workflow to happen when overall
workflow is created, instead of implicitly creating it if it
doesn't exist while checking for workflow status. The problem was
that the read check happens in multiple places and AJAX requests
were hitting it at the same time. Because repeatable-read mode
prevents them from seeing each others work, a couple of threads
would find that the peer workflow did not exist and would try to
create it. This cause integrity errors because those constraints
are enforced, even if those rows aren't available to other
processes.

This should have been fixed no matter what, but it's important to
note that Django should never be run under MySQL's default
repeatable-read mode. Use read-committed. For legacy reasons,
edX's own servers are misconfigured in this respect.

[TIM-262]

Run Details

1437 of 1590 relevant lines covered (90.38%)

0.9 hits per line