drecom / activerecord-turntable

90%

master: 91%

LAST BUILD ON BRANCH feature/backport_fix_to_add_association_scoping

branch: feature/backport_fix_to_add_association_scoping

CHANGE BRANCH

x

Reset

• feature/backport_fix_to_add_association_scoping
• add-ci-for-support-ar6.0.Z
• develop
• develop-3-0
• develop_1_x
• develop_2_x
• feature/add_matrix_test_target_rails_edge
• feature/add_rails5_1_2
• feature/add_rails_5_0_4
• feature/add_test_target_rails_v5_2_1
• feature/ar_import_duplication_warning
• feature/cleanup_test_models
• feature/configuration_dsl
• feature/disable_unstable_activerecord_test
• feature/disable_unstable_activerecord_tests_on_5_0_x
• feature/factory_girl
• feature/fix-ar-import
• feature/fix-clearing-active-connections-on-development
• feature/fix-fixtures-extensions
• feature/fix_abstract_adapter_log_argument_changes_on_5.0.3
• feature/fix_binary_insert
• feature/fix_boolean_insert_error
• feature/fix_code_styles
• feature/fix_connection_not_established_error_on_sti_models
• feature/fix_connection_proxy_nomethod_errors
• feature/fix_factory_bot_deprecation
• feature/fix_factory_bot_factory_definitions
• feature/fix_log_subscriber_format
• feature/fix_migrator_to_return_original_result
• feature/fix_no_method_error_disable_query_cache
• feature/fix_query_caching
• feature/fix_regression_log_subscriber_earlier_than_ar_5_0_3
• feature/fix_schema_dumper_comment
• feature/fix_schema_dumper_on_ar_5_0_0
• feature/fix_set_inverse_instance_compatibility_on_4_1
• feature/fix_to_add_association_scoping
• feature/fix_to_pass_transaction_options
• feature/fix_unindended_connection_increase
• feature/fix_weighted_shards_spec_to_check_array_exactly
• feature/fix_with_shard
• feature/fixes_error_on_turntable_configration_not_found
• feature/improve_configuration_file_path_detection
• feature/index_hint_fix
• feature/inspect_key_on_cannot_specify_shard
• feature/katsubushi_sequencer
• feature/merge-develop-3-0
• feature/optimize_travis_builds
• feature/patch_for_update_columns
• feature/rails4
• feature/rails42
• feature/rails51
• feature/rails515
• feature/rails516
• feature/rails516_and_507
• feature/rails52
• feature/refine_databases_rake_tasks
• feature/refurblish_configuration_loading
• feature/remake_configuration
• feature/remove_unused_helper_module
• feature/rubocop_offences
• feature/ruby2.5
• feature/run_activerecord_test
• feature/run_ci_on_each_tiny_releases
• feature/separate_turntable_pool_proxies_from_normal_owner_to_pool
• feature/speedup_rewind_databases
• feature/support_slave
• feature/unique_shard_key
• feature/update_4_2_patches
• feature/update_badges
• feature/update_rubocop
• feature/update_schema_dumper_patch
• feature/update_travis_ruby_versions
• feature/update_travis_target_versions
• fix-ci-matrix
• fix-nomethoderror-on-weighted-random-shard-with
• fix_rubocop_offences
• issue/16-fix-cluster-support-methods-when-lazy-loading
• katsubushi/seq-katsubushi
• master
• stable
• stable-2-x
• stable-3-x
• support-ar6.0.Z
• v1.1.1
• v1.1.2
• v2.0.0
• v2.0.0.rc1
• v2.0.2
• v2.0.3
• v2.0.4
• v2.0.5
• v2.0.6
• v2.1.0
• v2.1.0.beta1
• v2.1.0.beta2
• v2.1.0.rc1
• v2.1.0.rc2
• v2.1.1
• v2.2.0
• v2.2.1
• v2.2.2
• v2.3.0
• v2.3.1
• v2.3.2
• v2.3.3
• v2.4.0
• v2.5.0
• v3.0.0
• v3.0.0.alpha1
• v3.0.0.alpha2
• v3.0.0.alpha3
• v3.0.1
• v3.1.0
• v4.0.0
• v4.1.0
• v4.2.0
• v4.3.0
• v4.4.0
• v4.4.1

Build # 229

Build Type

push

travis-ci

Committed by gussan

Commit Message

Fix to propagate shard conditions to `AssociationRelation` too

backport from develop-3-0 branch

When calling `@user.tasks.find_by(name: 'xxx')`

before:

  SELECT `tasks`.* FROM `tasks` WHERE `tasks`.`name` = "xxx" # raises CannotSpecifyShardError

after:

  SELECT `tasks`.* FROM `tasks` WHERE `tasks`.`user_id` = 1 AND `tasks`.`name` = "xxx"

Run Details

32 of 32 new or added lines in 4 files covered. (100.0%)

2241 of 2490 relevant lines covered (90.0%)

3109.19 hits per line