donejs / donejs

96%

master: 97%

LAST BUILD ON BRANCH chat-update

branch: chat-update

CHANGE BRANCH

x

Reset

• chat-update
• 0.9-legacy
• 1.0-pmo-guide
• 2-docs
• 295-contribution-guide
• 629-page-switching
• 681-followup
• 681-upcoming-events
• 708-use-canjs-style-diff
• 765-socket-2
• 838-features-comparison
• 839-comparison
• 842-upgrade-guide
• 842-upgrade-guide-updates
• 908-js-bin
• 911-donejs-new-command
• 914-history
• 915-core-team
• 930-fix-blog-href
• 933-fix-donejs-help-command
• 943-include-route-helpers
• 959-npm-5
• Add-priority-label-links-to-“Finding-open-issues”
• a-win
• add-issue-and-pr-templates
• add-kd
• add-missing-new
• add-package-config
• add-yes
• alg-order
• appveyor-node8
• b3
• beta
• bin
• bit-docs-pre
• bitballs-stroke-spelling
• bitcentive-guide
• break
• can-debug
• can3
• cdn-feature
• change-detection-presentation
• chasenlehara-patch-1
• chat-cleanup
• chat-guide-1.0
• chat-guide-cleanup
• chat-guide-improvements
• chat-guide-models
• chat-guide-windows
• chat-updates
• ci
• city-option
• cli-fallthrough
• cli-refactor
• cli-tweaks
• clip
• contribution-guide-anchors
• correct-delete-http-method
• coverage-badge
• coveralls-send
• darth-veyor
• data-bindings-293
• debug-all
• dem-upd
• dev-setup-link-correction
• diff
• doc
• doc-place
• doc-test
• doc-things
• dollar
• donejs--add
• donejs-add-docs
• donejs-add-firebase
• donejs-electron
• donejs-readme-with-table
• err
• feat
• feat-mem
• feat-zone
• firebase
• firebaseid
• fix-add-issues
• fix-appveyor
• fix-build
• fix-code-hilighting
• fix-coveralls-badge
• fix-deploy-instructions
• fix-event-calender
• fix-in-depth-pmo-guide
• fix-license-for-guide
• fix-links
• fix-plurality
• fixes
• generator-final
• generator-guide
• generator-tweaks
• grammar-stuff
• greenkeeper/bit-docs-0.0.11
• greenkeeper/bit-docs-0.0.8
• greenkeeper/bit-docs-0.0.8-0
• greenkeeper/bit-docs-0.0.8-1
• greenkeeper/bit-docs-0.0.8-2
• greenkeeper/bit-docs-0.0.9
• greenkeeper/bit-docs-0.1.0
• greenkeeper/bit-docs-0.2.0
• greenkeeper/commander-2.10.0
• greenkeeper/commander-2.11.0
• greenkeeper/commander-2.15.0
• greenkeeper/commander-2.16.0
• greenkeeper/commander-2.17.0
• greenkeeper/commander-2.17.1
• greenkeeper/commander-2.18.0
• greenkeeper/commander-2.19.0
• greenkeeper/commander-2.20.0
• greenkeeper/commander-3.0.0
• greenkeeper/commander-3.0.1
• greenkeeper/commander-3.0.2
• greenkeeper/commander-4.0.0
• greenkeeper/commander-4.0.1
• greenkeeper/commander-4.1.1
• greenkeeper/commander-5.0.0
• greenkeeper/commander-5.1.0
• greenkeeper/commander-pin-2.15.0
• greenkeeper/commander-pin-2.9.0
• greenkeeper/cross-spawn-7.0.0
• greenkeeper/cross-spawn-7.0.1
• greenkeeper/cross-spawn-7.0.2
• greenkeeper/cross-spawn-7.0.3
• greenkeeper/es6-promise-4.1.1
• greenkeeper/es6-promise-4.2.5
• greenkeeper/es6-promise-4.2.6
• greenkeeper/es6-promise-4.2.7
• greenkeeper/es6-promise-4.2.8
• greenkeeper/initial
• greenkeeper/jshint-2.10.0
• greenkeeper/jshint-2.10.2
• greenkeeper/jshint-2.10.3
• greenkeeper/jshint-2.11.0
• greenkeeper/jshint-2.11.1
• greenkeeper/jshint-2.9.5
• greenkeeper/jshint-2.9.6
• greenkeeper/jshint-2.9.7
• greenkeeper/jshint-pin-2.9.7
• greenkeeper/mocha-3.3.0
• greenkeeper/mocha-3.4.0
• greenkeeper/mocha-3.4.1
• greenkeeper/mocha-3.4.2
• greenkeeper/mocha-3.5.0
• greenkeeper/mocha-3.5.1
• greenkeeper/mocha-3.5.2
• greenkeeper/mocha-4.0.0
• greenkeeper/mocha-4.0.1
• greenkeeper/mocha-4.1.0
• greenkeeper/mocha-5.0.0
• greenkeeper/mocha-5.0.1
• greenkeeper/mocha-5.0.2
• greenkeeper/mocha-5.0.3
• greenkeeper/mocha-5.0.4
• greenkeeper/mocha-5.0.5
• greenkeeper/mocha-5.1.0
• greenkeeper/mocha-5.1.1
• greenkeeper/mocha-5.2.0
• greenkeeper/mocha-6.0.1
• greenkeeper/mocha-6.0.2
• greenkeeper/mocha-6.1.0
• greenkeeper/mocha-6.1.1
• greenkeeper/mocha-6.1.2
• greenkeeper/mocha-6.1.3
• greenkeeper/mocha-6.1.4
• greenkeeper/mocha-6.2.0
• greenkeeper/mocha-6.2.1
• greenkeeper/mocha-6.2.2
• greenkeeper/mocha-7.0.1
• greenkeeper/mocha-7.1.0
• greenkeeper/mocha-7.1.1
• greenkeeper/mocha-7.1.2
• greenkeeper/mocha-7.2.0
• greenkeeper/mockery-2.1.0
• greenkeeper/node-fetch-1.7.0
• greenkeeper/node-fetch-1.7.1
• greenkeeper/node-fetch-1.7.2
• greenkeeper/node-fetch-1.7.3
• greenkeeper/node-fetch-2.0.0
• greenkeeper/node-fetch-2.1.0
• greenkeeper/node-fetch-2.1.1
• greenkeeper/node-fetch-2.1.2
• greenkeeper/node-fetch-2.2.0
• greenkeeper/node-fetch-2.2.1
• greenkeeper/node-fetch-2.3.0
• greenkeeper/node-fetch-2.4.0
• greenkeeper/node-fetch-2.4.1
• greenkeeper/node-fetch-2.5.0
• greenkeeper/node-fetch-2.6.0
• greenkeeper/q-1.5.1
• greenkeeper/q-pin-1.5.0
• greenkeeper/rimraf-2.6.3
• greenkeeper/rimraf-2.7.1
• greenkeeper/rimraf-3.0.0
• greenkeeper/rimraf-3.0.1
• greenkeeper/rimraf-3.0.2
• guide-improvements
• guide-test-branch
• guide-updates
• https-forums
• hubspot-analytics
• init
• inline-buttons
• js-bin
• jsbins
• kquery
• latest
• line-highlight
• linify-docs
• links
• major
• major-unlabeled-issues
• makefile
• master
• master-master
• mention-contribution-guide
• merge-master
• migrate2
• migrate3
• mikemitchel-patch-1
• mobile-h4
• more-docs
• node-version
• node8
• node8-no-package-lock
• nw-test
• one-site
• order-model
• patch
• plugin-guide
• pmo-guide-models
• pmo-issues
• pmo-url
• pmo-use-dotNotation
• presentations-list-update
• raw
• remove-documentjs
• remove-npm-cache-clean
• rename-binary-for-npm-link-version
• repo
• revert-1030-add-package-config
• revert-868-donejs-readme-with-table
• revert-885-revert-868-donejs-readme-with-table
• route-helpers-highlighting
• scoped-projects
• service-base-url
• setting-up
• setting-up-nodejs
• simple-deploy
• ssr-zones
• survey-page-updates
• test-tests
• tests
• third-party-generators
• tilde
• travis-node-8
• two-oh-docs
• typos
• unlabeled-issues
• update-deploy-instructions
• update-docs-ie9-to-ie11
• update-guide
• update-major
• update-presentations
• update-route-slug-syntax
• update-theme
• updating-bitballs-doc
• updating-deps
• upg
• upgrade
• upgrade-cmd
• upgrading-dependencies
• v0.10.0-pre.0
• v0.10.0-pre.1
• v0.9.0
• v0.9.1
• v0.9.2
• v1.0.0
• v1.0.0-alpha.1
• v1.0.0-alpha.3
• v1.0.1
• v1.1.0
• v1.1.0-beta.0
• v2.0.0
• v2.0.0-pre.0
• v2.0.0-pre.1
• v2.1.0
• v3.1.0
• v3.2.0
• ver1
• vers
• works
• yes

Build # 1693

Build Type

push

travis-ci

Committed by matthewp

Commit Message

Fix the ordering of implementing the Messages ViewModel

This fixes the order with which we implement the ability to send chat
messages. We need to update the ViewModel first, since it adds new
Define fields, and then update the template. This way it doesn't attempt
to define property on an already sealed ViewModel.

Closes #795

Run Details

107 of 111 relevant lines covered (96.4%)

8.81 hits per line