dockstore / data-object-service-plugin

83%

master: 83%

LAST BUILD ON BRANCH feature/1629/requires

branch: feature/1629/requires

CHANGE BRANCH

x

Reset

• feature/1629/requires
• 0.0.1
• develop
• feature/1654/prep
• feature/new-dos-dataguid
• master
• release/0.0.1

Build # 18

Build Type

Pull #3

travis-ci

Committed by web-flow

Commit Message

Don't break older versions of Dockstore CLI

ga4gh/dockstore#1629

One half of fix to not break older versions of Dockstore CLI when
this plugin is present in the ~/.dockstore/plugins directory.

In version 1.4 and earlier of Dockstore CLI
`VersionAwarePluginManager.getSystemVersion()` returns a Version
that represents `0.0.0`, the default; by specifying that this
plugin version requires >0.0.0. An upcoming PR to Dockstore Client
will change that version to 0.0.1.

When Dockstore CLI 1.4 runs, it will not attempt to load this plugin,
because of the requires requirement.

Fortunately, we are using an older version of the PF4J, as the
more recent versions interpret the 0.0.0 system version to mean
load all plugins without checking the version.

Pull Request Pull Request #3: Don't break older versions of Dockstore CLI

Run Details

52 of 63 relevant lines covered (82.54%)

0.83 hits per line