dmacvicar / terraform-provider-libvirt

54%

master: 29%

LAST BUILD ON BRANCH glide

branch: glide

CHANGE BRANCH

x

Reset

• glide
• cloud_init_user_data
• cpu_features
• destroy_destroyed_resource
• disks_from_http_url
• dmacvicar-git-commit-conventions
• document_output_count
• domain-filesystem
• fix_firmware_test_suse
• fix_hardcoded_file_pools
• fix_hardcoded_file_pools_2
• if_modified_since
• improve-test-coverage-low-hanging-fruits
• improved_wait_for_leases
• kernel_initrd
• keyless-kernel-cmdlines
• libvirt-stream-usage-ensure-cleanup
• lowercase_private_funs
• master
• more-tests
• multi_provider_2
• multi_provider_3
• network_improvs
• no_qemu_agent_as_default
• one_netdev_source_at_a_time
• revert-354-no_qemu_agent_as_default
• size_with_backing_volume
• update_dependencies_1
• update_libvirt_xml
• upstream-docs
• use-libvirt-fix-tests
• v0.1
• v0.2
• v0.4
• v0.4.1
• v0.4.2
• v0.4.3
• v0.4.4
• xslt_transform

Build # 367

Build Type

push

travis-ci

Committed by flavio

Commit Message

Fix broken tests by changing the way we vendor code

When I configured the project to use vndr and I broke the unit tests.

The tests were failing with these errors:

```
github.com/dmacvicar/terraform-provider-libvirt/vendor/github.com/hashicorp/terraform/builtin/providers/ignition

vendor/github.com/hashicorp/terraform/builtin/providers/ignition/provider.go:92:
undefined: types.SystemdUnit

vendor/github.com/hashicorp/terraform/builtin/providers/ignition/provider.go:93:
undefined: types.NetworkdUnit

vendor/github.com/hashicorp/terraform/builtin/providers/ignition/provider.go:94:
undefined: types.User

vendor/github.com/hashicorp/terraform/builtin/providers/ignition/provider.go:95:
undefined: types.Group
```

You can see the full log here:
https://travis-ci.org/dmacvicar/terraform-provider-libvirt

Terraform upstream doesn't have this problem because it vendors coreos ignition,
which has all these types defined inside of `vendor/github.com/coreos/ignition/config/types/unit.go`.

It turns out vndr is removing this file from our vendored terraform sources.

I tried to use the whitelist option to prevent that from happening but it didn't
work.
Moreover, it looks like the whitelists are not stored into the
`vendor.conf`, which means we would have to pass the flag every time we
interact with the vendor code!

With this commit we move from using vndr to use glide, which is not
affected by this issue.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>

Run Details

1424 of 2656 relevant lines covered (53.61%)

186.65 hits per line