dkubb / memoizable

100%

master: 100%

LAST BUILD ON BRANCH no-block-allowed

branch: no-block-allowed

CHANGE BRANCH

x

Reset

• no-block-allowed
• master
• devtools
• v0.3.0
• double-checked-locking
• v0.3.1
• memory_hash
• v0.4.0
• v0.4.1
• v0.4.2
• upgrade/dependencies

Build # 91

Build Type

push

travis-ci

Committed by dkubb

Commit Message

Change memoized method to not accept a block

* This is done because it is not possible to memoize a method that
  accepts a block.

  A method with a block could only be memoized if it were possible
  to know if the block provided was the same as an earlier block.
  However, each time a method executes the block has a new
  object_id. Also and it ranges from difficult to unsupported or
  impossible (depending on the ruby implementation) to get the
  block source.

  Not only would the source be necessary, but the runtime state of
  the block AST would be needed to compare against earlier seen
  blocks because it can reference anything within the current
  binding scope.

  Even heroic attempts like that in https://github.com/ngty/sourcify
  have a long list of caveats that make it inappropriate to use in
  a gem that is expected to always return the correct cached value.

  For these reasons and others it is currently impossible to memoize
  a method that accepts a block.

[Fix #6]

Run Details

107 of 107 relevant lines covered (100.0%)

126.08 hits per line