dgraph-io / dgraph

67%

main: 66%

LAST BUILD ON BRANCH aman/makefile

branch: aman/makefile

CHANGE BRANCH

x

Reset

• aman/makefile
• main
• release/v23
• aman/v23.0.1
• aman/fuzz
• aman/revert-normalize
• aman/ff
• joshua/coverage-security
• shiva/upgrade2
• joshua/pr-template
• aman/snap
• aman/minor
• aman/normalize
• aman/go-git
• joshua/coverage-fix
• aman/cleanup
• aman/checkout
• aman/ci
• jassi/zero_health_issue_5517
• joshua/dgraph-ci-fix
• oscs_fix_ci00k58au51qt1nt0is0
• aman/multitenancy-upgrade
• aman/upgrade-testing
• aman/simple
• aman/dgraphtest
• jassi/upgrade-multi-tenancy
• aman/restore-upgrade
• ahsan/check-deleteNS
• anurag/cp-rdf-over-http
• aman/test
• joshua-goldstein-patch-1
• raphael/local-test-lambda-acl
• aman/default
• joshua/add-workflow
• aman/upgrade
• aman/oss
• joshua/cves2
• joshua/cves
• siddesh/failed-download
• harshil/drop_op
• aman/dgo
• aman/matrix
• aman/flaky
• aman/wait
• u_testing_info
• shiva/nfs
• aman/unit
• shiva/backup
• aman/mac
• sanjayk/vscode-launch-json-fix
• cifuzz-int
• joshua/upgrade-tests
• aman/changelog
• skrdgraph/ci-frequency

Build # 5117788574

Build Type

push

Committed by web-flow

Commit Message

fix(bulk): removed buffer max size (#8841)

## Problem

On huge datasets, bulk import crashes with this stack trace:

```
panic: z.Buffer max size exceeded: 68719476736 offset: 68719476718 grow: 51

goroutine 421 [running]:
github.com/dgraph-io/ristretto/z.(*Buffer).Grow(0xc050d17c00, 0x33)
        /home/runner/go/pkg/mod/github.com/dgraph-io/ristretto@v0.1.1/z/buffer.go:180 +0x55b
github.com/dgraph-io/ristretto/z.(*Buffer).SliceAllocate(0xc050d17c00, 0x2f)
        /home/runner/go/pkg/mod/github.com/dgraph-io/ristretto@v0.1.1/z/buffer.go:266 +0x2e
github.com/dgraph-io/dgraph/dgraph/cmd/bulk.(*mapIterator).Next(0xc00e56f410, 0x3?, {0xc034740c40, 0x1d, 0x20})
        /home/runner/work/dgraph/dgraph/dgraph/cmd/bulk/reduce.go:206 +0x126
github.com/dgraph-io/dgraph/dgraph/cmd/bulk.(*reducer).reduce.func2()
        /home/runner/work/dgraph/dgraph/dgraph/cmd/bulk/reduce.go:486 +0x5aa
created by github.com/dgraph-io/dgraph/dgraph/cmd/bulk.(*reducer).reduce
        /home/runner/work/dgraph/dgraph/dgraph/cmd/bulk/reduce.go:476 +0x452
```

## Solution

Removing hard limit of 64GB to buffer sizes avoided panic and
successfully completed the import.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

58165 of 86823 relevant lines covered (66.99%)

2232922.88 hits per line