dgraph-io / badger

70%

main: 61%

LAST BUILD ON BRANCH blob-file-dev

branch: blob-file-dev

CHANGE BRANCH

x

Reset

• blob-file-dev
• ashish/restore-backward-compatibility
• ashish/read-bench
• gitlw/loading_kv_list
• ashish/test
• ashish/block-todos
• balaji/skl
• encryption
• balaji/iterator_improvement
• balaji/less_allocation
• balaji/preallocate
• balaji/block_cache
• balaji/vlog_reservation
• ashish/write-batch
• ibrahim/badger-warning-logs
• danielmai/badger-info-encryption
• main
• release/v3.2103
• release/v4.0
• main-deprecated
• release/v4
• joshua/token
• aman/memtable-flush
• aman/copy-levels
• joshua/badger-ci-patch
• dependabot/go_modules/golang.org/x/net-0.7.0
• fix-options
• readme-add-projects-1
• aman/incr
• aman/bug
• add-raft-badger
• aman/readme
• unsupported_manifest_url
• joshua/add-dgraph-workflow
• aman/options
• aman/xxhash
• harshil/unit_test_compaction_1
• aman/cleanup
• patch-1
• pub-after-wal
• subscribe-async
• joshua/v4.1.0
• joshua/release/v4-cl
• joshua/badger-deadlock
• joshua/security-scanning
• harshil/close_memtable
• kevin/close_memtable_wal
• fix-kr-right
• fixPageBufferReaderTry2
• FixPagebufferReader5
• harshil/backup_size_fix
• harshil/change_metric_name
• devcontainer
• FixTestTableChecksum
• 1847
• HandleDrainingClosedChannel
• DocSavage-patch-1
• FixDiscardStatsTest
• kevin/fix-comments
• oscs_fix_ci00kq0au51qt1nt0it0
• fix-test
• aman/sw
• joshua/security
• qmd12/fix-staticcheck-errors
• ioutil
• dependabot/go_modules/google.golang.org/grpc-1.53.0
• pkg-import
• harshil/fix-metricas
• fredcarle/fix/ref-decrease-on-close
• joshua/rfr
• issue-1923
• aman/changelog
• add-kvs-to-projects
• dev
• siddhant_jain/rollup_test
• typo
• aman/b1962
• aman/cobra
• optimize-allocations-in-compactor
• siddhant/upgrade-compress2
• joshua/ghost-jobs
• joshua/readme
• joshua/testing
• dependabot/go_modules/golang.org/x/net-0.17.0
• fix-empty-tx-bug
• fix-no-compression-table-cache
• dependabot/go_modules/google.golang.org/grpc-1.56.3
• fix-level-handler-zero-version
• master
• locker
• BaseTableSize
• sentinel-errors
• rft-codeowners
• update-ristretto
• fix-wasm
• rft-ci-cd-optimization
• feat_protobuf
• rft-ci-update

Build # 3675

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Fix flaky TestPageBufferReader2 test (#1210)

Fixes https://github.com/dgraph-io/badger/issues/1197

The `TestPageBufferReader2` test would fail often because of an
`off-by-1` issue. The problem can be reproduced by setting `randOffset`
to the biggest number that randInt31n may return statically like:

```
    //randOffset := int(rand.Int31n(int32(b.length)))
    randOffset := int(int32(b.length-1))
```

This makes the problem reliably reproducible as the offset is now
pointing at EOF.

Thus changing the line to this should hopefully solve the problem:
`randOffset := int(rand.Int31n(int32(b.length-1

Run Details

6927 of 9939 relevant lines covered (69.7%)

271998.16 hits per line