decentraland / comms-message-sfu
90%

DEFAULT BRANCH: main
Repo Added
Files 16
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 89.56% (+0.2%) from 89.356%
25503714461

push

github

web-flow 
fix: guard publishData against non-connected Room (#113)

* fix: guard publishData against non-connected Room

A recent dev SIGSEGV happened inside @livekit/rtc-node native code
during the SDK's internal reconnect. Independently, there is a
latent race in routeMessage where an in-flight routing call can
outlive a concurrent disconnect and end up invoking publishData on
a Room whose native state is being torn down — which can crash the
process.

Add a ConnectionState check before each publishData so we bail
cleanly (logged + failed metric) instead of touching torn-down
native handles.

Also bump @livekit/rtc-node ^0.13.14 -> ^0.13.27, which brings in
upstream fixes around FFI event ordering, waiting for the disconnect
response, and native handle disposal — all in the same crash class.

Switch @dcl/protocol to the experimental dist-tag so we keep
tracking the experimental branch where Chat.forwarded_from lives;
main dropped that field.

* chore: bail before DB lookups when Room is not connected; dedupe state tests

Address review comments:

- Add an early ConnectionState check before db.belongsToCommunity /
  db.getCommunityMembers so a routing call against an already-disconnected
  Room avoids two unnecessary queries before failing.
- Collapse the CONN_DISCONNECTED / CONN_RECONNECTING test pair into a
  single it.each, matching the convention in disconnected-handler.spec.ts.
- Add a test that exercises the per-batch guard specifically — connection
  state flips during the members lookup, so the early check passes but
  the publish-time guard still bails before publishData.

65 of 78 branches covered (83.33%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

261 of 286 relevant lines covered (91.26%)

8.99 hits per line

Relevant lines Covered
286 RELEVANT LINES 261 COVERED LINES
8.99 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25503714461 main fix: guard publishData against non-connected Room (#113) * fix: guard publishData against non-connected Room A recent dev SIGSEGV happened inside @livekit/rtc-node native code during the SDK's internal reconnect. Independently, there is a latent... push web-flow github
89.56
23498671554 main feat: forward chat reactions to community members (#104) Add support for routing ChatReaction messages through the SFU, using the same community membership validation as chat messages. The sender's address is overwritten with the verified LiveKit... push web-flow github
89.36
23198388069 main fix: batch community msgs sending (#100) push web-flow github
89.01
23191529809 main chore(deps): bump flatted from 3.3.3 to 3.4.1 (#98) Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.1. - [Commits](https://github.com/WebReflection/flatted/compare/v3.3.3...v3.4.1) --- updated-dependencies: - dependen... push web-flow github
88.99
23191526023 main chore(deps): bump ajv from 6.12.6 to 6.14.0 (#99) Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.6 to 6.14.0. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](https://github.com/ajv-validator/ajv/compare/v... push web-flow github
88.99
23191451998 main chore(deps): bump lodash from 4.17.21 to 4.17.23 (#93) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.1... push web-flow github
88.99
23191443114 main chore(deps): Bump @dcl/eslint-config from 2.2.1 to 2.4.3 (#82) Bumps [@dcl/eslint-config](https://github.com/decentraland/eslint-config) from 2.2.1 to 2.4.3. - [Release notes](https://github.com/decentraland/eslint-config/releases) - [Commits](ht... push web-flow github
88.99
23191436121 main chore(deps): Bump livekit-server-sdk from 2.13.0 to 2.15.0 (#78) Bumps [livekit-server-sdk](https://github.com/livekit/node-sdks/tree/HEAD/packages/livekit-server-sdk) from 2.13.0 to 2.15.0. - [Release notes](https://github.com/livekit/node-sdks/... push web-flow github
88.99
23191429230 main chore(deps-dev): Bump typescript from 5.8.3 to 5.9.3 (#57) Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.8.3 to 5.9.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/micro... push web-flow github
88.99
23191421583 main chore(deps-dev): Bump nodemon from 3.1.10 to 3.1.11 (#72) Bumps [nodemon](https://github.com/remy/nodemon) from 3.1.10 to 3.1.11. - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](https://github.com/remy/nodemon/compare/v3.1... push web-flow github
88.99
See All Builds (165)