dblock / slack-ruby-client

91%

master: 91%

LAST BUILD ON BRANCH fix-hash-inspect-format-drift

branch: fix-hash-inspect-format-drift

CHANGE BRANCH

x

Reset

Sync Branches

• fix-hash-inspect-format-drift
• 1-item-arg-groups
• 2.5.0-connection-options
• add-code-coverage
• added-ruby-3.4
• calm-down-the-cron
• chat-api-patch
• fix-apps-user-connection-group
• fix-channel-id
• fix-ci
• fix-coveralls
• fix-files-upload-v2-multiple-files
• fix-generator
• fix-markdown-text-mutual-exclusion
• gregsaab-add_files_upload_v2
• master
• migrate-danger-pr-comment
• milestruecar-async-cache-build-485
• oauth-file-upload-samples
• rack-3.0-rewind
• remove-rtm
• rid-code-climate
• support_channel_id_s
• translate-channels-file-upload

Build # 28751994615

Build Type

push

github

Committed by dblock

Commit Message

Render hash/array literals deterministically in generated specs

Ruby 3.4 changed Hash#inspect's default rendering of symbol keys from
the hash-rocket form (:foo=>1) to the modern shorthand (foo: 1). The
method_spec.erb template relied on implicit string interpolation of a
real Hash object when building the "encodes ... as json" test's
params, so the literal syntax emitted into generated spec files
depended on whichever Ruby version ran the generator. Since CI's
scheduled update_api.yml workflow pins Ruby 3.2, automated PRs could
flip-flop between hash-rocket and shorthand syntax on every run,
causing spurious diffs.

Add a ruby_literal helper that explicitly renders Hash/Array values as
source text using the modern key: value syntax (valid since Ruby 1.9,
well within our supported Ruby 2.7+ range), so generated output is
identical regardless of the Ruby version used to run
rake slack:web:api:update.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>

Coverage Stats

5245 of 5759 relevant lines covered (91.07%)

110.66 hits per line