daviddrysdale / c-ares

95%

master: 89%

LAST BUILD ON BRANCH issue60

branch: issue60

CHANGE BRANCH

x

Reset

• issue60
• acountry-fix
• bradh352-master
• cleanup
• contrib
• distcheck
• dns-dump
• docfix
• docs
• double-free
• fix-coverage
• fix33
• fixes
• fixlets
• fuzz
• fuzzname
• fuzztest
• iterative-free
• man-fix
• manfix
• manpage
• master
• max-indirs
• naptr
• newer-cmake
• norotate
• nschroot
• oldwin
• temp
• temp-force-appveyor
• temp-init
• temp-ports
• temp64
• tempfuzz
• tempios
• temppatch
• test
• test-for-merge
• travis
• utf-8
• win-suffix
• windump
• winfix

Build # 223

Build Type

push

travis-ci

Committed by daviddrysdale

Commit Message

ares_init_options: only propagate init failures from options

Commit 46bb820be3a8 ("ares_init_options: don't lose init failure")
changed init behaviour so that earlier errors in initialization
weren't lost.  In particular, if the user passes in specific
options but they are not applied (e.g. because of an allocation
failure), that failure needs to be reported back to the user; this
also applies when duplicating a channel with ares_dup().

However, other initialization failures can be ignored and
overridden -- in particular, if init_by_resolv_conf() or
init_by_environment() fail, then falling back to default values
is OK.

So only preserve failures from the init_by_options() stage, not
from all initialization stages.

Fixes issue 60.

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

3605 of 3778 relevant lines covered (95.42%)

3688.38 hits per line