dart-lang / analyzer_cli

62%

master: 68%

LAST BUILD ON BRANCH sdk_ext_fixes

branch: sdk_ext_fixes

CHANGE BRANCH

x

Reset

• sdk_ext_fixes
• a_opts_tests
• absolute_path_fix
• appveyor
• args-version
• bump-analyzer-dep
• cleanup
• ddc
• deprecate-null-aware-operators
• docs
• enable-new-task-model
• error_tests
• fix-no-package-case
• hint_counts
• initial_bits
• io_tests
• issue-23596
• kevmoo_pkg_test
• lint_flag
• master
• opts
• pack_cli
• pack_discovery
• plugin_tweaks
• port_tests
• pq-patch-1
• pr_dne
• props
• remove-bogus-lib-annotation
• sdk_constraint_fix
• sdk_detection
• sdk_ext_fixes_tests
• sethladd-patch-1
• super-mixins
• test_me
• usage_msg_fixes
• usage_tweaks
• v_bump
• version_bump

Build # 153

Build Type

push

travis-ci

Committed by stereotype441

Commit Message

Fix .packages file discovery on Windows.

The _discoverPackagespec() method was trying to convert its "root"
argument to a directory URI (one ending in a "/") by calling "new
Uri.directory(root.path)".  This was causing confusion on Windows,
since root.path is in posix-style but the Uri.directory constructor
expects a native OS path.

Fortunately, the caller always passes a directory URI anyhow, so no
conversion is necessary.  We can just use the URI as is.

Run Details

311 of 503 relevant lines covered (61.83%)

13.59 hits per line