danmayer / coverband

89%

master: 89%

LAST BUILD ON BRANCH v5.0.1.rc.1

branch: v5.0.1.rc.1

CHANGE BRANCH

x

Reset

• v5.0.1.rc.1
• 4_0_1_readme_updates
• 4_2_5
• add-code-of-conduct-1
• add-unused-file-callout
• add_file_hash_to_coverage_data
• add_report_coverage_method
• add_runtime_relavent_coverage
• add_second_persist_coverage_call
• add_standardrb
• add_view_times
• additional_simplecov_remove_on_readme
• alternate_delete_in_setup
• alternative_patch
• at_exit_for_all
• avoid_double_hash_calc
• background_check
• batch_call_lua
• batch_files_hash_redis_store
• batch_hash_redis_save_report
• benchmark_report_coverage_memory
• benchmark_subset_of_files
• benchmark_with_coverage_data
• bug/fix_missing_web_report_requires
• bundle_require_eager_loading
• bundler_issues
• cache_lua_installation
• cache_wiggle
• change_to_hash
• chat_badge
• clarify_support
• clean_up_payload
• cleanup
• cleanup_previous_coverage_logic
• cleanup_static
• combined
• coverage_server_environment
• coverband_5_readme_updates
• dead_background_thread_on_fork
• dead_method_scanning
• development_stuck_eager_loading
• disable_resque_integration_when_disable_autostart
• document_disable_autostart
• exp_2
• extract_delta_coverage_class
• feature/coverage_time
• feature/experiment
• feature/fix_bad_merges
• feature/gem_tracking
• feature/migration
• feature/move_to_marshal
• feature/relative_path_in_store
• feature/runtime_coverage_ui
• file_helpers_and_hashes
• filter_files_in_place
• fix_bootup_issues
• fix_bundler_to_old_version_again
• fix_disable_auto_start_for_rails
• fix_for_4_x
• fix_for_resque_runtime_coverage
• fix_ignore_issues
• fix_last_updated_at_in_new_adapter
• fix_rake_at_exit_issue
• fix_rake_coverage
• fix_redis_out_of_date_file
• fix_regression_on_non_hit_files
• fix_rubocop
• fix_static_html
• fork_each_process_coveralls
• fork_each_test
• fork_integration_tests
• gem_improvements
• hash_counter_store
• hash_redis_store_using_lua
• improve_string_allocations
• improved_config
• increase_hash_redis_store_save_report_batch_size
• isolate_test_redis
• jruby
• later_loading
• list_all_gems
• lua_install_script_install_new_lua_rocks
• master
• memory_conscious_redis_store
• memory_conscious_redis_store_oj
• memory_conscious_redis_store_oj_mimic
• memory_improvements
• middleware_no_longer_reports
• mini_profile_tests
• move_filters_drop_gem_support
• move_synchronize_up
• move_web_endpoint_under_report_section
• msg_pack
• no_custom_code_required
• pipeline_hash_redis_store_coverage
• prepend_eager_load
• previous_coverage_file
• rack_server_for_rake_task
• rails_dummy_background_frequency
• rails_full_stack_manual_report_in_test
• rails_init_benchmarks
• readme_touchups
• real_file_logger_adapter
• reduce_footprint_when_not_using_web_reporter
• refactor_add_not_loaded_files
• refactor_tests_match_dir
• remove_binding_pry_committed_on_accident
• remove_classifer_reborne
• remove_custom_travis_bundler_stuff_maybe
• remove_debug_statement
• remove_dependency_on_environment_task
• remove_eager_loading_debug_statement
• remove_force_report
• remove_get_report
• remove_rack_dependency
• remove_readme_simplecov_section
• remove_simple_cov_dependency
• remove_unneccessary_dup
• replace_redis_store_with_hash
• require_unique_files_in_tests
• reset_collector_on_configure
• reset_coverage_each_test
• resque_support
• revert-274-list_all_gems
• run_lua_tests_on_travis
• scan_method_body
• separate_eager_load_coverage
• separate_lua_source
• set_skip_runtime_hit_on_eager_load
• slight_simplification_on_array_diff
• spike_on_lua
• sporadic_resque_test_failure
• standardrb_fixes
• support_coverage_options
• support_haml_slim_by_default
• test_additions_to_coverage_test
• test_files_exclude_benchmark
• test_report_coverage_verbose_exception
• test_without_skipping_first_report
• track_gems_readme_update
• try_2_6_1
• try_different_bundle_install
• try_with_firefox
• use_coverband_report_coverage
• use_flushdb
• v4.0.1
• v4.0.1.beta
• v4.1.0
• v4.1.0.beta
• v4.1.1
• v4.2.0
• v4.2.0.alpha
• v4.2.0.beta
• v4.2.0.rc1
• v4.2.0.rc2
• v4.2.0.rc3
• v4.2.1
• v4.2.1.rc1
• v4.2.1.rc2
• v4.2.1.rc3
• v4.2.1.rc4
• v4.2.2
• v4.2.2.rc.1
• v4.2.3
• v4.2.3.rc.2
• v4.2.4
• v4.2.4.rc.1
• v4.2.4.rc.2
• v4.2.4.rc.3
• v4.2.5
• v4.2.5.rc.1
• v4.2.5.rc.2
• v4.2.6
• v4.2.7
• v4.2.7.rc.1
• v5.0.0
• v5.0.0.rc.3
• v5.0.0.rc.4
• v5.0.0.rc.5
• v5.0.0.rc.6
• v5.0.0.rc.7
• v5.0.0.rc.8
• v5.0.1
• v5.0.2
• v5.0.3
• v_4_2_7
• view_tracker
• webdrivers_gem

Build # 1944

Build Type

push

travis-ci

Committed by danmayer

Commit Message

A race condiiton could occur when setting the redis for the view tracker

This commit moves the creation of the view tracker and subscription to active support notifications until after we have run the users custom config block... previously the view tracker would run before a users custom config could set the store `config.store` with a redis URL... So it would default to REDIS_URL from the env, even if the user set it to say COVERBAND_REDIS_URL in their custom config... This bug could only effect folks that had multiple redises and were trying to run Coverband on a Redis that wasn't associated with the REDIS_URL env.

When this bug occered we would save view_tracker information tot he REDIS_URL redis instance and then report them from the on configured by the users custom config.

Run Details

1595 of 1796 relevant lines covered (88.81%)

168.4 hits per line