curationexperts / epigaea

90%

master: 90%

LAST BUILD ON BRANCH file-type

branch: file-type

CHANGE BRANCH

x

Reset

• file-type
• add-coveralls-badge
• add-purge-remove-review-buttons
• add_collection_to_sample_file
• admin_sets_breaking
• advanced-search/feature-spec
• advanced-search/field-suffix
• af-base-wo-id
• analytics
• application-actor
• batch-edit-spec
• batch-index
• batch-optionals
• batch-search
• batch_email_user
• batch_import_testing
• batch_user_creation
• better-readme
• bugfix/adding_work_to_collection
• bugfix/attach_work_to_collection
• bugfix/blank_display_name
• bugfix/ignore_date_created
• catch_object_not_found
• check_for_well_formed_xml
• clean-db-metadata-import
• clean_up_specs
• cleaner-dot-env
• collection-export
• collection-on-import
• collection-re-import
• complex-batch-import
• config_mailer
• contribute_specs
• createdby_multiple
• css-collections-table
• css-metadata-import
• de-dupe_feature_tests
• default_admin_set_stats
• default_mail
• delete_spec
• dependency-update
• disable_travis_emails
• do_not_send_email_in_dev_env
• docs
• draftable-specs
• empty_rights_statement
• enable_video_derivatives
• ensure-nil-for-singular
• feature-defaults
• feature/ajax-pagination-for-batches
• feature/check_for_valid_id
• feature/collection_ead_field
• feature/collection_seeds
• feature/ldap
• feature/ldap-email
• feature/load_workflow_on_deploy
• feature/modified-uploaded-show
• feature/normalize-import-fields
• feature/notifications_refactored
• feature/only_one_id_on_batch_update
• feature/revert-drafts-button
• feature/suppress_individual_notifications
• feature/technical-metadata
• filter-selfdeposit
• finish-transcript-front-end-features
• fits_not_found
• fix-help-keyword-warning
• fix-ignore-date-uploaded
• fix-show
• fix/add-creator-term
• fix/admin-non-admin-routes
• fix/advanced-search-date-created
• fix/advanced-search-results
• fix/batch-create-forms
• fix/batch-edit-spec
• fix/batch-edit-spec-
• fix/collections-pages
• fix/delete-draft-with-contoller
• fix/embargo_note
• fix/env_defaults
• fix/file_upload_limit
• fix/gis_poster_description
• fix/handle-admin-set-predicate
• fix/potral-portal
• fix/remove-tufts-filename-from-tech-metadata
• fix/repopulate-fields-on-form
• fix/right-statement-param
• fix/rights-statement-forms-transcript
• fix/rights-statement-scalar-multivalue
• fix/rights-twice-on-form
• fix/search-constraints
• fix/self-deposit
• fix/show-view
• fix/sidekiq-link
• fix/technical-metadata
• fix/technical-metadata-formatting
• fix/unpublished-visibility-in-collection
• fix/upload_limit
• fix/uploaded-fade-in
• fix_held_by_facet
• fix_intermittent_fail
• fix_predicates
• fixup-xml-import-enqueue
• handle-config
• handle-dl
• handle-dot-env
• handle-url
• ignore-coverage
• import-file-upload
• inherit-behaviors
• inter-fail
• inverse_association
• investigate_failed_spec
• issue-813
• key-not-found
• ldap-wip
• mail_setup
• mark-dce-patch-1
• mark_dirty
• master
• metadata_table
• multi-file-import
• no-creator
• okcomputer
• order_desc
• ordered_creator
• ordered_export
• recent_export_spec
• redis-store-update
• refactor/batch-edit-spec
• refactor/rep-and-thumbnail-assignment
• register_ead_field
• register_handle_upon_publication
• reinstate_test
• remove_pending
• require_display_in
• required_fields
• restart_on_cap_deploy
• restrict_sample_data_to_dev
• revert-677-fix/batch-create-forms
• sample-xml-5-records
• sample-xml-files
• sample_data_rake_task
• sample_import_file
• sample_input_file
• sample_meta_file
• search/by-batch
• security_updates
• self-deposit/abstract
• self-deposit/refactor-abstract
• self_dep_note_spec
• session-store-flash
• setup-models
• sidekiq_link
• sign-out
• spec/drafts-editable-coverage
• spec/editable
• spec/make-xml-import-presenter-status-optional
• spec/mark-assigns-template-as-optional
• spec/mark-draft-saved-as-optional
• spec/mark-flappy-specs-as-optional-on-travis
• spec/mark-import_object-as-optional
• spec/mark-xml-import-presenter-spec-as-optional
• spec/optional-for-publish-unpublish
• spec/refactor-user-roles-in-factories
• statistics
• story_861
• style/add-metadata-button
• style/remove-blank-wells
• submission-date
• template-upload_fade_in
• template_notifications
• template_spec
• thumbnail-sample-xml-file
• ticket_649
• ticket_668
• ticket_753
• trailing-whitespace
• turbolinks-batch-fix
• unauthenticated_users_redirect
• update_docs
• update_fixture
• update_member_of_queries
• update_missing_attributes
• upgrade/hyrax-2.0.0
• upload-fade-in
• use-models
• use-models-rc2
• user-name
• v2017.12.07.beta
• v2017.12.13.beta
• v2017.12.21.beta
• v4.0.0-rc3
• v4.0.0-rc4
• v4.0.0-rc5
• v4.0.0-rc6
• v4.0.0-rc7
• v4.0.0-rc8
• v4.0.0-rc9
• v4.0.0rc1
• v4.0.0rc2
• validate_collections_exist
• view/deposit-types-non-auth
• views/add-controls-to-batches
• visibility-round
• whitespace-deposit
• xml-import-failures
• xml-import-no-requeue

Build # 2098

Build Type

push

travis-ci

Committed by no-reply

Commit Message

Allow setting file types on file_sets within a work via XmlImport

Supports setting filetypes in XML batch imports by passing `type="transcript"`
as an attribute on an XML file.

Callers to the Actor Stack's `#create` method can now pass a filename to each of
the `:transcript`, `:representative`, and `:thumbnail` to force the stack to set
these roles when an item is attached to the work.

Unfortunately, we need to overwrite significant parts of the Hyrax ActorStack to
achieve this goal. The attach files part of the stack is run in a background
job, making it challenging to extend. We create customized versions of a
standard Hyrax actor (`CreateWithFilesAndPassTypesActor`) and a job to handle
the setting (`AttachTypedFilesToWorkJob`). The first allows passthrough of the
required arguments to the job. These arguments must be deleted before the work`s
actor is called to prevent errors on the unknown attributes. The Job overwrite
ensures that the roles are set before the `FileSetActor` (which is, confusingly,
neither an actor, nor in the stack) runs and tries to use its own setting
strategies.

ImportRecord is extended to recognize file roles from the `type` XML attribute,
and the import service passes these roles to the actor stack, triggering the
above setting.

Closes #632.

Run Details

2448 of 2714 relevant lines covered (90.2%)

85.43 hits per line