ctxswitch / kafkat

62%

master: 66%

LAST BUILD ON BRANCH airbnb_ruby_style

branch: airbnb_ruby_style

CHANGE BRANCH

x

Reset

• airbnb_ruby_style
• 27
• add_coveralls
• add_topic_delete
• create_new_runclass_interface
• finish_style_cleanup
• fix_42
• import_rubocop_yml
• issue_4
• master
• new_gem
• reduce_config_load_complexity

Build # 31

Build Type

Pull #13

travis-ci

Committed by web-flow

Commit Message

Airbnb has their own style guide

I just ran across the Airbnb ruby style guide.  I'm not tied to any
specific style and had previously adapted the modified shopify guide to
fill a gap.  I've added the new gem and updated the requirement.  This
does break some of the previous style decisions, so I generated the todo
file to exclude the breaking styles and we can work through them as we
go.  I also added the spec directory back in and am including those
issues for future updates.

I did overide a couple of specific stylistic choices, notably:

```
Layout/AlignParameters:
  EnforcedStyle: with_fixed_indentation
  SupportedStyles:
  - with_first_parameter
  - with_fixed_indentation
  IndentationWidth:

Layout/DotPosition:
  EnforcedStyle: leading
  SupportedStyles:
  - leading
  - trailing
```

IMHO, the alignment of parameters and the dot positions can get messy in
the longer lines, so I tend to prefer this specific indentation style.

Added the tmp directory used by rubocop in the todo generation to the
gitignore file.

Pull Request Pull Request #13: Airbnb has their own style guide

Run Details

586 of 948 relevant lines covered (61.81%)

5.59 hits per line