cryo28 / sidekiq_status

98%

master: 98%

LAST BUILD ON BRANCH utilize-sidekiq-jid

branch: utilize-sidekiq-jid

CHANGE BRANCH

x

Reset

• utilize-sidekiq-jid
• 1.0.6
• 1.0.7
• 1.1
• 1.1.0
• 1.2.0
• experimental-support-for-rubinius
• experimental-support-for-rubinius-and-jruby
• master
• ncuesta-sidekiq-4.2-support
• prepare_for_2.14

Build # 115

Build Type

push

travis-ci

Committed by cryo28

Commit Message

Use Sidekiq::Worker#jid instead of replacing job arguments with jid

When SidekiqStatus was developed, sidekiq did not support the notion of
jid - so the result value of Sidekiq::Worker.perform_async was a
truthy/falsey value, not a unique jid.

Because of that SidekiqStatus had to introduce that and massage job
arguments back and forth.

Nowadays, sidekiq generates jid for each individual job on its own and
Sidekiq::Processor ensures that Sidekiq::Worker#jid attr_reader is assigned
to the jid of the currently processing job.

Because of that, there is no need for SidekiqStatus to do this
arguments massaging anymore.

This commit removes this argument massaging and relies of
Sidekiq::Processor to setup Sidekiq::Worker#j anymore.

This commit removes this argument massaging and relies of
Sidekiq::Processor to setup Sidekiq::Worker#jid

Hopefully this change should simplify the code need to make
SidekiqStatus work together with retry jobs middleware and
sidekiq_unique_jobs (pending)

Run Details

570 of 584 relevant lines covered (97.6%)

206.57 hits per line