coveo / tgf

15%

master: 44%

LAST BUILD ON BRANCH restore-basic-custom-name

branch: restore-basic-custom-name

CHANGE BRANCH

x

Reset

• restore-basic-custom-name
• add-current-user-option
• add-no-docker-build-arg
• add-option-to-disable-aws
• alias-improvements
• allow-configuration-from-secrets-manager
• allow-local-image
• best-effort-prune
• child-config-overwrite
• config-without-ssm
• current-user-windows
• current-version-tests
• current-version-tests-OO
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.19.47
• dependabot/go_modules/github.com/aws/aws-sdk-go-1.20.2
• dependabot/go_modules/github.com/hashicorp/go-getter-1.3.0
• dind-fix
• ecr-login
• feature/DT-1515-docker-non-interactive
• feature/dt-1631-latest-version-s3
• feature/dt-4-auto-update
• feature/dt-4-with-windows
• fix-alias-equal-arguments
• fix-config-overwrite
• fix-credentials-bug
• fix-docker-mount-mac
• fix-help
• fix-image-name
• fix-issue-54
• fix-negative-arguments
• fix-unmanaged-bug
• get-latest-tgf-script
• hash-source
• inject-version-number
• master
• move-to-coveooss
• my-contribution
• rebuild-image-if-changed
• recursive-aliases
• refactoring
• refresh-image
• refresh-partial-versions
• remove-bad-characters-from-tags
• secrets-manager-acount
• slight-adjustments
• support-aliases
• support-different-ssm-path
• support-hcl
• v1.18.0
• v1.18.1
• v1.18.2
• v1.18.3
• v1.18.4
• v1.18.5
• v1.18.6
• v1.18.7
• v1.18.8
• v1.19.0
• v1.19.0-beta.1
• v1.19.1
• v1.19.2
• v1.19.3
• v1.19.4
• v1.19.5
• v1.20.0
• v1.20.1
• v1.20.2
• v1.20.3
• v1.21.0
• v1.21.0-beta1
• v1.21.0-beta2
• with-docker-option

Build # 694

Build Type

Pull #44

travis-ci

Committed by web-flow

Commit Message

Restore the custom naming based on config location

The initial goal was to easily identify custom images instead of just having an anonymous hash to identify them. We then added a hash to ensure that we rebuild the image if the custom DockerFile or the custom build folder content changed and finally, we removed the name, thus  loosing the identification of the custom image and returning to an anonymous image as we did originally.

It is still important to not rebuild the custom image if there is no change and rebuild it if there is a change. So, I simply added the hash into a label and instead putting the hash into the name, we simply check if the label has changed to determine if the image should be rebuilt.

Pull Request Pull Request #44: Restore the custom naming based on config location

Run Details

20 of 20 new or added lines in 2 files covered. (100.0%)

140 of 905 relevant lines covered (15.47%)

0.74 hits per line