contao / manager-plugin

72%

LAST BUILD ON BRANCH develop

branch: develop

CHANGE BRANCH

x

Reset

• develop
• 0.1.0
• 0.1.1
• 0.2.0
• 1.0.0
• 1.0.1
• 2.0.0
• 2.0.1
• 2.1
• 2.1.0
• 2.1.1
• 2.1.2
• 2.2
• 2.2.0
• 2.2.0-RC1
• 2.2.0-beta1
• 2.2.0-beta2
• 2.2.1
• 2.3
• 2.3.0
• 2.3.1
• 2.4
• 2.4.0
• 2.4.1
• 2.5
• 2.5.0
• 2.6
• 2.6.0
• 2.6.1
• 2.6.2
• 2.7
• 2.7.0
• 2.7.1
• 2.8
• 2.8.0
• composer-plugin
• composer-stable
• feature/api-plugin
• feature/autoloader
• feature/plugin-cache
• hotfix/1.0.1
• hotfix/2.0.1
• hotfix/2.0.2
• hotfix/provider-version
• master
• travis-test

Build # 110

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Store the current plugins in the PluginLoader class (see #9)

Description
-----------

This implementation stores the current plugins inside the `PluginLoader` class, similar to [ocramius/package-versions](https://github.com/ocramius/PackageVersions).

There are multiple major advantages to that:
 1. The `PluginLoader` no longer needs to be initialized by "guessing" the position of the `installed.json`
 2. There will no longer be a `bundles.map` file in the cache that needs to be rebuild on every container build
 3. The `PluginLoader` becomes independent of the kernel, which means the `contao-api` can also use plugins to perform functionality
 4. Making `contao/manager-plugin` a Composer plugin enables use to add composer-related event handling in the future without needing to add command to the root composer.json (e.g. https://github.com/contao/core-bundle/issues/1223)

There is only one disadvantage I can find: Because the file is overwritten, Composer will complain about git differences on a develop version.

@contao/developers please give your general opinion so I can finish this (unit tests etc.)

Commits
-------

23fbfdfc Dump the PluginLoader from Composer information
c677af58 Can't var_export class instances to a private variable.
cef114ae Fixed PluginLoader namespace
be21942c Enabled plugin existance check
9914932f Dump the class name from string
a91a5cbc Add full namespace to exported classes
761f5dc9 Store disabled packages in the root composer.json
a8e45124 Use serialize/unserialize to store plugins
e3f7c0b0 CS
844d0c7a Dynamically set the date in copyright header
65fd0e4f Fix the coding style.
8f614a92 Make Symfony 3.3 the minimum requirement (Contao 4.3 does not support Symfony <3.3).

Run Details

79 of 79 new or added lines in 3 files covered. (100.0%)

204 of 282 relevant lines covered (72.34%)

4.52 hits per line