containous / flaeg

90%

master: 90%

LAST BUILD ON BRANCH v1.4.1

branch: v1.4.1

CHANGE BRANCH

x

Reset

• v1.4.1
• add-GetBoolFlags-func
• add-GetFlags-func
• add-coveralls
• add-metadata
• agrs-case-insensitive
• beautiful-help
• cocap10-update-readme
• commands-improvement
• continue-on-error-missing-parser
• enhancement/usage
• fix-ascii-art
• fix-defalt-values-pointer
• fix-empty-args
• fix-no-flags-panic
• fix-parser-type-conversion
• fix-unexported-field
• fix/default-values-pointer
• master
• parser-improvement
• parser-structag-refactor
• pointer-under-pointer-set-value
• refactor-GetCommand
• revert-12-parser-improvement
• v0.5.0
• v1.0.0
• v1.0.1
• v1.1.0
• v1.1.1
• v1.1.2
• v1.2.0
• v1.3.0
• v1.4.0

Build # 219

Build Type

push

travis-ci

Committed by ldez

Commit Message

use ParseInt instead of Atoi for parsing durations (#52)

Flaeg is failing to deserialize durations with values >= to 2^32 on 32 bits architectures.
This is caused by the usage of `Atoi` to parse duration, which returns an `int` not an `int64`.

During a JSON unmarshall of a duration for values >= to 2^32, Atoi will
return an error and flaeg will try to parse the value as a string, which
is going to fail too, causing the unmarshalling to fail.

Using `ParseInt(s, 10, 64)` fixes the problem, as it works on an int64.

Run Details

610 of 677 relevant lines covered (90.1%)

96.39 hits per line