connorads / lockbot

100%

push

github

Cover remaining reachable branches, ignore unreachable ones

Coveralls aggregates lines+branches from lcov, so 7 unmeasured branches
dragged the PR to 95.6% despite 99%+ line coverage.

- Unit-test command-parsers and the api/types decoders directly: they
  were only exercised over HTTP via serverless-offline, a process
  boundary the in-process v8 provider cannot see across.
- v8-ignore the two branches unreachable under test infra: the prod arm
  of the IS_OFFLINE ternary (needs real AWS) and the result.Items else
  path (DynamoDB Local always returns Items).
- Rework getFirstParam to the destructure-default idiom parseUnlock
  already uses: the `[0] ?? ""` fallback was dead (split returns >=1
  element) and could not be hint-ignored - vite 8's oxc SSR transform
  only preserves statement-leading comments, so expression-level
  `v8 ignore` hints never reach the remapper.

Rejected: Coveralls lines-only toggle (off-repo, invisible config) and
excluding api/infra.ts wholesale (it is loaded in-process by
api-app.test.ts; targeted ignore keeps the rest measured).

lcov now reports 136/136 lines and 45/45 branches.

45 of 45 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

136 of 136 relevant lines covered (100.0%)

17.72 hits per line