codeforamerica / human_services_finder

97%

master: 90%

LAST BUILD ON BRANCH js-error-handling

branch: js-error-handling

CHANGE BRANCH

x

Reset

• js-error-handling
• 10_market_match
• 123_alert_noshow
• 148-fix-history
• 194_scroll_position
• 194_scroll_to_top
• 249-fix-result-summary
• 251-js-error
• 253-fix-211-text
• 274_classlist_null
• 28-human-readable-urls
• 297-alert-box-pos
• 53_clickable_terms
• 60_superscript_name
• 66_media_queries
• 70_close_btn
• 73_mq_osm_credit
• 83_hide_search_options
• 89_firefox_fix
• add-category-param
• add-details
• add-distance-line
• add-hook-for-project-monitor
• add-kind-filter
• ajax-app
• alphabetize_products
• api-token
• bg-height
• blitz
• branding
• bug-fixes
• caching
• canonical-url-for-details
• category-search
• category-search-transition
• cip-data
• code-refactor
• critical-security-fix
• details-formatting
• details_styling
• devel
• develop
• disable-nearby-feature
• domready-fix
• edit-button
• filters-adjustments
• fix-accessibility
• fix-assets-precompilation
• fix-detail-search
• fix-google-analytics
• fix-map-hiding
• fix-tests
• floating-header
• font-awesome-integration
• fragment-caching
• ga-event-tracking
• google-analytics
• google-translate-detection
• hide-datalist-ie
• hide-popups
• html-validation
• http-caching
• icon-fallback
• ie-comments
• ie-fix
• ie-fixes
• increase-timeout
• keyboard-events
• keyword-prompts
• kind-category-filter
• logging
• major-overhaul
• map-cleanup
• map-icons
• map-refactor
• map-url-fix
• map-view
• master
• microdata
• missing-coords
• mobile-layout
• mobile-refactor
• nearby-map
• no-results-map-fix
• oe-categories
• page-numbers
• poltergeist-integration
• popup-arrow
• printing-styles
• readme-phantomjs-fix
• refactor-view-helpers
• remove-211
• remove-boilerplate
• remove-loading-manager
• remove-location-popup
• remove-unused-font-refs
• removes-map
• rspec-formatting
• single-request-detail
• specs-with-vcr
• static-map
• status-endpoint
• style-guide
• translation
• translation-cookie
• travis-to-staging
• unicorn-setup
• update-results
• ux-updates
• validates-formatting-of
• viz-distance

Build # 819

Build Type

push

travis-ci

Committed by anselmbradford

Commit Message

Fixes map loading errors

- Map initialization was hooked into AJAX search loading so that a AJAX
callback is provided to the map to enable it to route location clicks
through an AJAX request. However, AJAX search is currently disabled so
the map was not being initializing properly and was not loading. This
commit fixes the issue by completely removing AJAX-related modules from
the module loading sequence and initializing the maps directly within
their page route initializers.

- If the Google Maps API timed out the maps failed to load. This commit
adds RequireJS error hooks on the route initializers that loads
"no-map" versions of the map manager modules, which handle cleanup by
hiding the map container HTML and displaying an alert message to the
user to try reloading the page or sending feedback. This occurs after a
7 second timeout so the map will display blank for the first seven
seconds before being hidden.

Run Details

183 of 189 relevant lines covered (96.83%)

122.34 hits per line